Incorporated changes for release 1.3.2

Incorporated changes for 1.3.1
Incorporated changes for release 1.3.0
2026-02-24 20:13:13 -05:00 · 2026-02-24 20:07:34 -05:00 · 2026-02-24 19:59:54 -05:00
39 changed files with 1566 additions and 648 deletions
--- a/50
+++ b/50
@@ -1,5 +1,5 @@
    OpenDRS - Online Discrepancy Reporting System
-    Copyright (C) 2018  Rod Wright
+    Copyright (C) 2022  Rod Wright

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -75,3 +75,51 @@ Changelog
 	- Added ability to customize the terminology used for Device,
 		Period, and Effective/Non-effective to make OpenDRS usable in
 		a wider range of applications.
+
+1.3.0 - 2022-03-05
+	- Made several improvements to group functionality. The Writeup Groups
+		page now displays all groups in a table instead of individually
+		expandable sections. On the View Writeups and View Open Writeups
+		pages, if a writeup is a member of only one group, clicking the
+		icon will take you to the page for that group. If a writeup is
+		a member of multiple groups, clicking the icon will take you to
+		the detail page for that writeup where you can view or modify which
+		groups the writeup is a member of. On the Search page, you can
+		now choose which group(s) the results should include.
+	- Made some improvements to the installation process for Raspberry Pi
+		setup to accomodate the latest version of Raspberry Pi OS.
+	- If setting up as a Raspberry Pi terminal/server, included the option
+		to make the terminal a wireless access point if it connects to an
+		ethernet network.
+
+1.3.1 - 2022-05-11
+	- Updated installation scripts and instructions to reflect changes in
+		Raspberry Pi OS Release 2022-04-04.
+		
+1.3.2 - 2022-08-08
+	- Fixed typo in dbadmin.php that prevented adding new When Discovered
+		items.
+	- Fixed bug in create.php that prevented the page from working.
+	- Fixed bug in config.php that prevented banners from being modified.
+	- Fixed bug where action_by and action_reason were not preselected for
+		subsequent searches in search.php.
+	- Fixed bug in about.php and gpl.php that still used old $mts_db
+		database handle.
+	- Removed the server session directory option in config.php
+		Miscellaneous settings. For this to make sense, you'd have to have
+		shell access to the server and if that's the case, you'd be able
+		to make the necessary database changes as well.
+	- Fixed opendrs-initial.sql to make the default banner colors match
+		the ones in common.php.
+	- Created changelog.php for use by the "changes" link on the About
+		page so kiosk terminal users don't get dead-ended in the CHANGELOG
+		text file with no way to get back to the app.
+	- Extensive code cleanups/updates in all php files to make application
+		compatible with php8 and eliminate php warnings in apache2 error
+		log file.
+	- For Raspberry Pi:
+		- Updated server-setup.sh to attempt to install the php-mysqli package
+			for compatibility with php8.
+		- Chromium browser will use the printer designated as the local
+			default if it is selected as such in the Cups printer
+			configuration.
--- a/RPiSetup/ap-setup.sh
+++ b/RPiSetup/ap-setup.sh
@@ -0,0 +1,115 @@
+#!/bin/bash
+
+#    ap-setup.sh
+#    OpenDRS Online Discrepancy Reporting System
+#    Copyright (C) 2022  Rod Wright
+
+#    SPDX-License-Identifier: GPL-2.0
+
+# Wireless Access Point Raspberry Pi Setup
+current_user=`whoami`
+if [ "$current_user" != "root" ]
+then
+	echo "You must have root privileges to run this setup."
+	echo "Try 'sudo ./ap-setup.sh'"
+	exit 1
+fi
+echo ""
+echo ""
+echo "If this terminal connects to a network using ethernet, it can be configured"
+echo "as a wireless access point for other terminals. Would you like to configure"
+echo -n "this terminal as an access point? [y/N]: "
+read wapconf
+if [ "$wapconf" = "Y" -o "$wapconf" = "y" ]
+then
+	echo "Configuring as wireless access point."
+	echo ""
+	echo "Copying files..."
+	chmod +x apsetup/usr/local/bin/*
+	cp apsetup/usr/local/bin/* /usr/local/bin
+	cp -R apsetup/etc/* /etc
+	echo ""
+	wapssidok=0
+	while [ "$wapssidok" -ne 1 ]
+	do
+		echo "This access point will need an SSID. This is what will appear"
+		echo "as the name of this terminal when other devices connect."
+		echo -n "Please enter the desired SSID for this access point:  "
+		read wapssid
+		if [ "$wapssid" = "" ]
+		then
+			echo "SSID cannot be blank. Try again."
+		else
+			wapssidok=1
+		fi
+	done
+	wappassok=0
+	while [ "$wappassok" -ne 1 ]
+	do
+		echo "You will need to set a passphrase for this access point. It should"
+		echo "be at least 8 characters in length and cannot be blank."
+		echo -n "Please enter the desired passphrase for this access point:  "
+		read wappass
+		wappasslen=`echo -n $wappass | wc -m`
+		if [ "$wappass" = "" -o "$wappasslen" -lt 8 ]
+		then
+			echo "Passphrase doesn't satisfy requirements above. Try again."
+		else
+			wappassok=1
+		fi
+	done
+	apt install hostapd
+	systemctl unmask hostapd
+	systemctl enable hostapd
+	echo "[NetDev]" >/etc/systemd/network/bridge-br0.netdev
+	echo "Name=br0" >>/etc/systemd/network/bridge-br0.netdev
+	echo "Kind=bridge" >>/etc/systemd/network/bridge-br0.netdev
+	echo "[Match]" >/etc/systemd/network/br0-member-eth0.network
+	echo "Name=eth0" >>/etc/systemd/network/br0-member-eth0.network
+	echo "" >>/etc/systemd/network/br0-member-eth0.network
+	echo "[Network]" >>/etc/systemd/network/br0-member-eth0.network
+	echo "Bridge=br0" >>/etc/systemd/network/br0-member-eth0.network
+	systemctl enable systemd-networkd
+	mv /etc/dhcpcd.conf /etc/dhcpcd.conf.old
+	echo "denyinterfaces wlan0 eth0" >/etc/dhcpcd.conf
+	cat /etc/dhcpcd.conf.old >>/etc/dhcpcd.conf
+	echo "interface br0" >>/etc/dhcpcd.conf
+	rfkill unblock wlan
+	echo "country_code=US" >/etc/hostapd/hostapd.conf
+	echo "interface=wlan0" >>/etc/hostapd/hostapd.conf
+	echo "bridge=br0" >>/etc/hostapd/hostapd.conf
+	echo "ssid=$wapssid" >>/etc/hostapd/hostapd.conf
+	echo "hw_mode=g" >>/etc/hostapd/hostapd.conf
+	echo "channel=7" >>/etc/hostapd/hostapd.conf
+	echo "macaddr_acl=0" >>/etc/hostapd/hostapd.conf
+	echo "auth_algs=1" >>/etc/hostapd/hostapd.conf
+	echo "ignore_broadcast_ssid=0" >>/etc/hostapd/hostapd.conf
+	echo "wpa=2" >>/etc/hostapd/hostapd.conf
+	echo "wpa_passphrase=$wappass" >>/etc/hostapd/hostapd.conf
+	echo "wpa_key_mgmt=WPA-PSK" >>/etc/hostapd/hostapd.conf
+	echo "wpa_pairwise=TKIP" >>/etc/hostapd/hostapd.conf
+	echo "rsn_pairwise=CCMP" >>/etc/hostapd/hostapd.conf
+	wget -c http://github.com/pjz/webmin-modules/releases/download/v1.0/hostap.wbm.gz
+	gzip -d hostap.wbm.gz
+	/usr/share/webmin/install-module.pl hostap.wbm
+	echo ""
+	echo ""
+	echo "Wireless access point setup is complete. It will be"
+	echo "automatically enabled after reboot. To change the SSID or"
+	echo "passphrase in the future, edit the file /etc/hostapd/hostapd.conf"
+	echo "or use the Host AP module in the Servers section of Webmin."
+	echo ""
+	echo "To disable the access point altogether in the future, run:"
+	echo "	sudo wap-disable"
+	echo "at a command prompt and reboot the terminal. To re-enable it, run:"
+	echo "	sudo wap-enable"
+	echo "at a command prompt and reboot the terminal."
+	echo "It can also be enabled or disabled via Custom Commands in the Tools"
+	echo "section of Webmin."
+	echo ""
+	echo -n "Press enter key to continue..."
+	read cont
+else
+	exit 2
+fi
+
--- a/RPiSetup/apsetup/etc/webmin/custom/1630026603.cmd
+++ b/RPiSetup/apsetup/etc/webmin/custom/1630026603.cmd
@@ -0,0 +1,3 @@
+sudo wap-enable
+Enable Wireless Access Point
+pi 0 1 0 0 0 0 0 -
--- a/RPiSetup/apsetup/etc/webmin/custom/1630026603.html
+++ b/RPiSetup/apsetup/etc/webmin/custom/1630026603.html
@@ -0,0 +1 @@
+
--- a/RPiSetup/apsetup/etc/webmin/custom/1630026756.cmd
+++ b/RPiSetup/apsetup/etc/webmin/custom/1630026756.cmd
@@ -0,0 +1,3 @@
+sudo wap-disable
+Disable Wireless Access Point
+pi 0 1 0 0 0 0 0 -
--- a/RPiSetup/apsetup/etc/webmin/custom/1630026756.html
+++ b/RPiSetup/apsetup/etc/webmin/custom/1630026756.html
@@ -0,0 +1 @@
+
--- a/RPiSetup/apsetup/etc/webmin/custom/1630027149.edit
+++ b/RPiSetup/apsetup/etc/webmin/custom/1630027149.edit
@@ -0,0 +1,11 @@
+/etc/hostapd/hostapd.conf
+Edit Wireless Access Point Parameters
+
+
+
+
+systemctl restart hostapd
+0
+0
+
+
--- a/RPiSetup/apsetup/etc/webmin/custom/1630027149.html
+++ b/RPiSetup/apsetup/etc/webmin/custom/1630027149.html
@@ -0,0 +1 @@
+
--- a/RPiSetup/apsetup/etc/webmin/custom/config
+++ b/RPiSetup/apsetup/etc/webmin/custom/config
@@ -0,0 +1,8 @@
+display_mode=1
+params_file=0
+params_cmd=0
+columns=1
+height=
+wrap=
+width=
+sort=
--- a/RPiSetup/apsetup/usr/local/bin/wap-disable
+++ b/RPiSetup/apsetup/usr/local/bin/wap-disable
@@ -0,0 +1,4 @@
+#!/bin/bash
+systemctl stop hostapd
+systemctl disable hostapd
+
--- a/RPiSetup/apsetup/usr/local/bin/wap-enable
+++ b/RPiSetup/apsetup/usr/local/bin/wap-enable
@@ -0,0 +1,4 @@
+#!/bin/bash
+systemctl enable hostapd
+systemctl start hostapd
+
--- a/RPiSetup/apsetup/usr/local/bin/wap-setpassphrase
+++ b/RPiSetup/apsetup/usr/local/bin/wap-setpassphrase
@@ -0,0 +1,16 @@
+#!/bin/bash
+newppok=0
+while [ "$newppok" -ne 1 ]
+do
+	echo -n "New passphrase: "
+	read newpp
+	newpplen=`echo -n $newpp | wc -m`
+	if [ "$newpp" = "" -o "$newpplen" -lt 8 ]
+	then
+		echo "Passphrase didn't satisfy requirements. Try again or hit <ctrl>-c to abort."
+	else
+		newppok=1
+	fi
+done
+sed -i "/wpa_passphrase=.*/c wpa_passphrase=$newpp" /etc/hostapd/hostapd.conf
+systemctl restart hostapd
--- a/RPiSetup/apsetup/usr/local/bin/wap-setssid
+++ b/RPiSetup/apsetup/usr/local/bin/wap-setssid
@@ -0,0 +1,15 @@
+#!/bin/bash
+newssidok=0
+while [ "$newssidok" -ne 1 ]
+do
+	echo -n "New SSID: "
+	read newssid
+	if [ "$newssid" = "" ]
+	then
+		echo "SSID cannot be blank. Try again or hit <ctrl>-c to abort."
+	else
+		newssidok=1
+	fi
+done
+sed -i "/ssid=.*/c ssid=$newssid" /etc/hostapd/hostapd.conf
+systemctl restart hostapd
--- a/RPiSetup/etc/drs.conf
+++ b/RPiSetup/etc/drs.conf
@@ -1,2 +1,25 @@
+# drs.conf
+
+# URL for OpenDRS
 DRS_SERVER="http://localhost"

+# Set to "1" to prevent screen blanking on some monitors that go to sleep and won't wake up.
+INHIBIT_BLANK="0"
+
+# For standard DRS functionality
+APP_CMD="chromium-browser --test-type --ignore-certificate-errors --kiosk --no-first-run --check-for-update-interval=1 --simulate-upgrade --incognito $DRS_SERVER"
+ALIVE_STRING="chromium-browse"
+KILL_CMD="killall chromium-browser"
+CLEANUP_CMD="rm -rf ~/.{config,cache}/chromium/"
+
+# Notes
+# --test-type will ignore any warnings and
+# --ignore-certificate-errors will allow you to kiosk any https-page without displaying certificate errors
+
+#-----------------------------------------------------------------------
+# For test use
+#APP_CMD="xterm"
+#ALIVE_STRING="xterm"
+#KILL_CMD="killall xterm"
+#CLEANUP_CMD="sleep 1"
+
--- a/RPiSetup/server-setup.sh
+++ b/RPiSetup/server-setup.sh
@@ -2,7 +2,7 @@

 #    server-setup.sh
 #    OpenDRS Online Discrepancy Reporting System
-#    Copyright (C) 2021  Rod Wright
+#    Copyright (C) 2022  Rod Wright

 #    SPDX-License-Identifier: GPL-2.0

@@ -11,6 +11,13 @@ docroot_path="/var/www"
 apache_user="www-data"
 apache_group="www-data"

+current_user=`whoami`
+if [ "$current_user" != "root" ]
+then
+	echo "You must have root privileges to run this setup."
+	echo "Try 'sudo ./server-setup.sh'"
+	exit 1
+fi
 echo ""
 echo ""
 echo ""
@@ -20,7 +27,7 @@ echo ""
 echo ""
 echo "You should have already run the terminal-setup.sh script in this directory."
 echo ""
-if [ ! -e "/etc/drs.conf" ] 
+if [ ! -e /etc/drs.conf ] 
 then
    echo "It looks like the terminal-setup.sh script has not been run yet."
    echo "This is required before running the server-setup.sh script."
@@ -50,23 +57,40 @@ echo ""
 echo "IMPORTANT!: Be sure to make note of usernames and passwords you provide below."
 echo "You will need them later."
 echo ""
-echo "Installing required server packages. Select apache2 as the web server to configure"
-echo "automatically. Choose Yes when prompted to install phpmyadmin database and allow it to"
-echo "generate a random password(leave the field blank)."
+echo "Installing required server packages. You will be prompted about a couple of things:"
+echo ""
+echo "- Select apache2 as the web server to configure automatically."
+echo ""
+echo "- Choose Yes when prompted to install phpmyadmin database and allow it to"
+echo "	generate a random password(leave the field blank)."
+echo ""
 echo -n "Press enter to continue."
 read continueok
 echo ""
 echo ""
 echo ""
 echo ""
-apt install -y apache2 php php-mcrypt mariadb-server phpmyadmin uuid-runtime
+apt install -y apache2 php mariadb-server phpmyadmin uuid-runtime
+apt install -y php-mysqli 
 cp etc/apache2/mods-available/alias.conf /etc/apache2/mods-available
 service apache2 restart
 echo "...done."
 echo ""
 echo ""
-echo "Configuring the mysql installation. Accept the defaults at the following prompts."
-echo "Remember the password you set here. You'll need it during the OpenDRS install."
+echo "Configuring the MariaDB installation. There will be some more prompts:"
+echo ""
+echo "- You'll be prompted for the current password for the root user. You've"
+echo "	just installed MariaDB and you haven't set one yet, so just press enter."
+echo ""
+echo "- You'll be prompted to switch to unix_socket authentication. Answer Y."
+echo ""
+echo "- You'll be prompted to change the root password. Answer Y and enter a password."
+echo "	Note that this is just the password for the MariaDB root user, not the terminal."
+echo "	DO NOT FORGET THIS PASSWORD. You'll need it later during OpenDRS install."
+echo ""
+echo "- Answer Y to remove anonymous users, disallow root login remotely, remove"
+echo "  test database and access, and reload privilege tables."
+echo ""
 echo -n "Press enter to proceed."
 read continueok
 echo ""
@@ -74,7 +98,6 @@ echo ""
 echo ""
 echo ""
 mysql_secure_installation
-mysql mysql -e "update user set plugin='';flush privileges;"
 echo ""
 echo ""

@@ -85,9 +108,13 @@ bad_mysql_adm=1
 while [ $bad_mysql_adm -eq 1 ]
 do
    admintestdb="drsadm`date +%Y%m%d`"
+    echo "Starting OpenDRS installation."
+    echo ""
    echo "We need to know the username and password of a MySQL administrator"
-    echo "to be able to create the database and user for OpenDRS. Note that this"
-    echo "is not necessarily the same as the login and password for the computer."
+    echo "to be able to create the database and user for OpenDRS. The username"
+    echo "will be root and the password will be the one you were urged to remember"
+    echo "a minute ago."
+    echo ""
    echo -n "MySQL admin username: "
    read mysql_adm_user
    echo ""
@@ -100,7 +127,7 @@ do
        bad_mysql_adm=0
    else
        echo "ERROR: Either the username/password you supplied were incorrect or the user"
-        echo -n "is not a MySQL administrator. Try again? [Y/N]: "
+        echo -n "is not a MySQL administrator. Try again? [y/N]: "
        read admtry
        if [ "$admtry" != "Y" -o "$admtry" != "y" ]
        then
@@ -208,6 +235,10 @@ fi
 echo "Installing distribution . . ."
 cp -Rv ../distfiles/* $install_path
 ln -s $install_path/writeups.php $install_path/index.php
+if [ ! -L "$install_path/jquery-ui" ]
+then
+	ln -s $install_path/jquery-ui* $install_path/jquery-ui
+fi
 echo ""
 echo ""
 echo ""
@@ -222,9 +253,11 @@ echo "Enter the user and group separated by a colon (username:groupname)."
 echo "Enter the user:group of the OpenDRS installation"
 echo -n "directory [$apache_user:$apache_group] :"
 read httpd_user_group_in
-if [ "$http_user_group_in" != "" ]
+if [ "$httpd_user_group_in" != "" ]
 then
-	http_user_group=$http_user_group_in
+	httpd_user_group="$httpd_user_group_in"
+else
+	httpd_user_group="$apache_user:$apache_group"
 fi
 echo ""
 echo "Setting file ownership . . ."
@@ -246,6 +279,26 @@ echo "<Directory $install_path>" >> /etc/apache2/conf-available/$inst_name.conf
 echo "    Options FollowSymLinks" >> /etc/apache2/conf-available/$inst_name.conf
 echo "    DirectoryIndex index.php" >> /etc/apache2/conf-available/$inst_name.conf
 echo "</Directory>" >> /etc/apache2/conf-available/$inst_name.conf
+grep -q "<title>Apache2 Debian Default Page: It works</title>" /var/www/html/index.html
+if [ -$? -eq 0 ]
+then
+	echo "This apache installation appears to be new or unconfigured. Replacing the default"
+	echo "site index page with a more useful one."
+	site_hostname=`hostname`
+	mv /var/www/html/index.html /var/www/html/defaultindex.html
+	echo "<!doctype html>
+	<html lang=en>
+	<head>
+	<meta charset=utf-8>
+	<title>$site_hostname</title>
+	</head>
+	<body>
+	<p>
+	<a href=\"http://$site_hostname/$inst_name/\">$inst_name</a>
+	</p>
+	</body>
+	</html>" > /var/www/html/index.html
+fi
 	
 a2enconf $inst_name
 service apache2 reload
@@ -265,4 +318,4 @@ echo "REMEMBER THESE CREDENTIALS. Otherwise, you will not be able to log in and"
 echo "configure your new installation."
 echo "It is highly recommended that you change the initial password to something"
 echo "secure after logging in for the first time."
-echo "DRS_SERVER=\"http://localhost/$inst_name\"" > /etc/drs.conf
+sed -i 's,'DRS_SERVER=.*','DRS_SERVER="\"http://localhost/$inst_name/\""',' /etc/drs.conf
--- a/RPiSetup/terminal-setup.sh
+++ b/RPiSetup/terminal-setup.sh
@@ -2,10 +2,18 @@

 #    terminal-setup.sh
 #    OpenDRS Online Maintenance Tracking System
-#    Copyright (C) 2021  Rod Wright
+#    Copyright (C) 2022  Rod Wright

 #    SPDX-License-Identifier: GPL-2.0

+current_user=`whoami`
+current_login=`who am i | awk '{print $1}'`
+if [ "$current_user" != "root" ]
+then
+	echo "You must have root privileges to run this setup."
+	echo "Try 'sudo ./terminal-setup.sh'"
+	exit 1
+fi
 echo ""
 echo ""
 echo ""
@@ -16,20 +24,30 @@ echo ""
 echo "You should have already completed the following steps:"
 echo ""
 echo "1. Created a Raspberry Pi OS Lite SD card from the latest release."
-echo "2. Installed the card in a Raspberry Pi, booted it, and logged in as pi."
+echo ""
+echo "2. Installed the card in a Raspberry Pi, booted it, and completed"
+echo "    initial configuration."
+echo ""
 echo "3. Ran sudo raspi-config and :"
-echo "     a. Set a strong password for the pi user."
-echo "     b. Set hostname and, if accessing a network through wifi, the SSID and"
-echo "         passphrase under Network Options."
-echo "     c. Set locale, timezone, keyboard layout, and wifi country under"
-echo "         Localisation Options."
-echo "     d. Enable SSH under Interfacing Options."
-echo "     e. Set overscan as required to get rid of any black borders around the"
-echo "         edge of the display."
-echo "     f. Reboot when prompted and logged back in as pi."
-echo "4. Transferred the OpenDRS distribution package to /home/pi on the"
+echo "     a. Set locale, timezone, and WLAN Country under"
+echo "         Localisation Options. "
+echo ""
+echo "     b. Set hostname and Boot / Auto Login to Console under System Options."
+echo ""
+echo "     c. If accessing a network through wifi, the Wireless LAN SSID"
+echo "         and passphrase under System Options."
+echo ""
+echo "     d. Enable SSH under Interface Options."
+echo ""
+echo "     e. Set underscan as required under Display Options to get rid of any"
+echo "         black borders around the edge of the display."
+echo ""
+echo "     f. Reboot when prompted and logged back in as $current_login."
+echo ""
+echo "4. Transferred the OpenDRS distribution package to /home/$current_login on the"
 echo "    Raspberry Pi and extracted it."
-echo "5. Changed directory to RPiSetup in the the extracted distribution directory."
+echo "5. Changed directory to RPiSetup in the extracted distribution directory."
+echo ""
 echo ""
 echo "If you have completed these steps, press enter to continue. If not,"
 echo -n "press ctrl-c to quit."
@@ -56,6 +74,7 @@ echo ""
 echo "Copying files..."
 chmod +x usr/local/bin/*
 cp usr/local/bin/* /usr/local/bin
+cp etc/drs.conf /etc
 cp etc/apt/sources.list.d/* /etc/apt/sources.list.d
 cp lib/systemd/system/getty@tty1.service /lib/systemd/system
 echo ""
@@ -72,14 +91,17 @@ echo ""
 echo ""
 echo ""
 echo ""
-wget http://www.webmin.com/jcameron-key.asc
-apt-key add jcameron-key.asc
+echo "deb https://download.webmin.com/download/repository sarge contrib" >/etc/apt/sources.list.d/webmin.list
+wget https://download.webmin.com/jcameron-key.asc
+cat jcameron-key.asc | gpg --dearmor >/etc/apt/trusted.gpg.d/jcameron-key.gpg
 rm jcameron-key.asc
+apt install apt-transport-https
 apt update
 apt install -y --no-install-recommends xorg openbox chromium-browser
-apt install -y webmin cups libcups2-dev cmake
+apt install -y cups libcups2-dev cmake
+apt install -y webmin
 addgroup lpadmin
-usermod -a -G lpadmin pi
+usermod -a -G lpadmin $current_login
 systemctl enable getty@tty1.service
 service cups-browsed stop
 systemctl disable cups-browsed.service
@@ -101,14 +123,13 @@ echo "of your choosing."
 echo -n "Press enter to continue."
 read continueok
 echo ""
-echo ""
 echo "Creating customer user..."
 sleep 10
 echo ""
 echo ""
 echo ""
 echo ""
-cloneuser `who am i | awk '{print $1}'` customer
+cloneuser $current_login customer
 mkdir -p /home/customer/.config/openbox
 cp home/customer/.profile /home/customer
 cp home/customer/.config/openbox/rc.xml /home/customer/.config/openbox
@@ -127,24 +148,50 @@ read server_url
 if [[ $server_url == "" ]]
 then
    conftype="Server/Terminal"
-    touch /etc/drs.conf
    ./server-setup.sh
 else
    conftype="Terminal"
-    echo "DRS_SERVER=\"$server_url\"" > /etc/drs.conf
+    sed -i 's,'DRS_SERVER=.*','DRS_SERVER="\"$server_url\""',' /etc/drs.conf
+fi
+echo ""
+echo ""
+./ap-setup.sh
+if [ $? -ne 0 ]
+then
+	echo "If you would like to configure this terminal as an access point at some"
+	echo "time in the future, log in, change directory to the"
+	echo "extracted distribution's RPiSetup directory, and run:"
+	echo "  sudo ./ap-setup.sh"
 fi
 echo ""
 echo ""
 echo "$conftype configuration is now complete. "
 echo ""
 echo ""
-echo "It is highly recommended that after rebooting, you run ssh pi@$HOSTNAME"
+echo "It is highly recommended that after rebooting, you run ssh $current_login@$HOSTNAME"
 echo "from another computer on the network, then create new users for"
-echo "yourself and any other administrators using the cloneuser command"
-echo "(cloneuser pi <new username>)."
+echo "any other administrators using the cloneuser command"
+echo "(cloneuser $current_login <new username>)."
 echo ""
 echo ""
-echo "Setup complete."
-echo -n "Press enter to reboot now."
+echo "Terminal setup complete."
+echo ""
+if [ "$conftype" = "Terminal" ]
+then
+	echo "If you would like to use this terminal as a DRS server, after rebooting"
+	echo "and logging back in, change directory to the extracted distribution's"
+	echo "RPiSetup directory, and run:"
+	echo "  sudo ./server-setup.sh"
+	echo ""
+fi
+echo ""
+echo "A reboot is required to start using this terminal."
+echo -n "Would you like to reboot now? [Y/n]: "
 read rebootok
-reboot
+if [ "$rebootok" = "N" -o "$rebootok" = "n" ]
+then
+	exit 0
+else
+	reboot
+fi
+
--- a/RPiSetup/usr/local/bin/startdrs.sh
+++ b/RPiSetup/usr/local/bin/startdrs.sh
@@ -1,32 +1,37 @@
 #!/bin/bash
+# startdrs.sh
 
 source /etc/drs.conf

 openbox-session &
 
-xset s off
-xset +dpms
-xset dpms 0 600 1800
+if [ "$INHIBIT_BLANK" -eq "1" ]
+then
+	xset s off
+	xset -dpms
+else
+	xset s off
+	xset +dpms
+	xset dpms 0 600 1800
+fi

 while true
 do
-  killall chromium-browser
-  rm -rf ~/.{config,cache}/chromium/
+  $KILL_CMD
+  $CLEANUP_CMD
  
-  # start browser to DRS Server
-  # --test-type will ignore any warnings and 
-  # --ignore-certificate-errors will allow you to kiosk any https-page without displaying certificate errors
-  chromium-browser --test-type --ignore-certificate-errors --kiosk --no-first-run --check-for-update-interval=1 --simulate-upgrade --incognito $DRS_SERVER &
+  # start application
+  $APP_CMD &
 
  sleep 10
 
  while true
  do
-    pgrep chromium-browse
+    pgrep $ALIVE_STRING
    if [ "$?" -eq "1" ]
    then
-         # relaunch browser if it terminates
-         chromium-browser --test-type --ignore-certificate-errors --kiosk --no-first-run --check-for-update-interval=1 --simulate-upgrade --incognito $DRS_SERVER & 
+         # relaunch application if it terminates
+         $APP_CMD & 
    fi
    sleep 1
  done
--- a/RaspberryPiSetup.txt
+++ b/RaspberryPiSetup.txt
@@ -2,42 +2,37 @@ Raspberry Pi setup

 1. Create Raspberry Pi OS Lite SD card from the most recent stable release.

-2. Insert SD card in Raspberry Pi and boot.
+2. Insert SD card in Raspberry Pi, boot it, and complete initial config.

-3. Login as pi.
+3. run sudo raspi-config and:
    
-4. sudo raspi-config and:
-    
-    a. Set a strong password for the default user (pi).
-    
-    b. Set the desired hostname.
-    
-    c. Set Wireless LAN SSID and passphrase if using WiFi for networking.
-    
-    c. Use Localisation Options to:
+    a. Use Localisation Options to:
        1. Set locale to en_US.UTF-8 UTF-8.
        2. Set timezone.
-        3. Set keyboard layout (IMPORTANT! Raspberry Pi OS is made in 
-			England, so unless that's the kind of keyboard you have, the
-			default layout will make your symbols come out wrong!).
-        4. Set WLAN country.
+        3. Set WLAN country.
    
-    d. Use Interfacing Options to enable SSH server.
+    b. Use System Options to:
+		1. Set the hostname.
+		2. Set Boot / Auto Login to Console.
+		3. If accessing the network through WiFi, set the Wireless LAN
+			SSID and passphrase.
 	
-    e. If you have black borders on the sides of the screen, use Display
-        Underscan option to change Overscan compensation.
+	c. Under Interface Options, enable SSH.
 	
-    f. When you've finished, tab down to highlight Finish and hit enter.
+	d. Under Display Options, set underscan as required to get rid of
+		black screen borders.
 	
-    g. Reboot when prompted.
+	e. When you've finished, tab down to highlight Finish and hit enter.
    
-    h. Log back in as pi using the password you set in a. above.
+    f. Reboot when prompted.
    
-5. Copy OpenDRS distribution package to /home/pi on the Raspberry Pi and extract.
+    g. Log back in as the user you created during initial configuration.

-6. Change directory to the extracted distribution.
+4. Copy OpenDRS distribution package to the Raspberry Pi and extract.

-7. Change directory to RPiSetup.
+5. Change directory to the extracted distribution.

-8. run sudo ./terminal-setup.sh
+6. Change directory to RPiSetup.
+
+7. run sudo ./terminal-setup.sh

--- a/TODO.txt
+++ b/TODO.txt
@@ -1,6 +1,11 @@
 TODO

- Provide ability to change terminology for "device", "period", and
-    "effective" to broaden the use case for the application.
+- Add ability to save/restore configuration.

- Get Chromium to remember printer selection across reboots.
+- Add ability to backup/restore writeups.
+
+- Add a $border_visible debug variable to the end of settings.php and 
+	use it wherever there's a "border=\"0\"" to be able to see and fix 
+	table layout issues.
+
+- Automate installation on servers running Nginx as well as Apache.
--- a/boilerplate.php
+++ b/boilerplate.php
@@ -2,12 +2,17 @@
 /*
    boilerplate.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to index.php on cancel button press
 if ($_REQUEST['cancel']) {
@@ -18,38 +23,46 @@ if ($_REQUEST['cancel']) {
 }

 // import session variables
-if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];
+if (isset($_SESSION['userid'])) {
+	$userid=$_SESSION['userid'];
+} else {
+	$userid=NULL;
+}

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
-    // form as "all_parameters" so we need to load those into $incoming
+    // form as "all_parameters" so we need to load those into $incoming[]
    $incoming=unserialize($_REQUEST['all_parameters']);
+    
 } else {
-    // copy $_REQUEST to $incoming 
+    // copy $_REQUEST[] to $incoming[] 
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-
-
-// define local functions
-
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+ * possible keys are:
+ * 
+ */
 
 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
-    $sbcolor=P_SIDEBAR_COLOR;
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
-    $sbcolor=SIDEBAR_COLOR;
    $mbgcolor=MENUBG_COLOR;
 }

 $role=dblookup($drs_db,"users","id","role",$userid);

+// define local functions
+
+
+
+
 framework("begin","$appname","Boilerplate Page",$print);

 //echo "_REQUEST array <br>";
--- a/db.php.template
+++ b/db.php.template
@@ -3,7 +3,7 @@
 /*
    db.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */
--- a/distfiles/CHANGELOG
+++ b/distfiles/CHANGELOG
@@ -1,5 +1,5 @@
    OpenDRS - Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -75,3 +75,51 @@ Changelog
 	- Added ability to customize the terminology used for Device,
 		Period, and Effective/Non-effective to make OpenDRS usable in
 		a wider range of applications.
+
+1.3.0 - 2022-03-05
+	- Made several improvements to group functionality. The Writeup Groups
+		page now displays all groups in a table instead of individually
+		expandable sections. On the View Writeups and View Open Writeups
+		pages, if a writeup is a member of only one group, clicking the
+		icon will take you to the page for that group. If a writeup is
+		a member of multiple groups, clicking the icon will take you to
+		the detail page for that writeup where you can view or modify which
+		groups the writeup is a member of. On the Search page, you can
+		now choose which group(s) the results should include.
+	- Made some improvements to the installation process for Raspberry Pi
+		setup to accomodate the latest version of Raspberry Pi OS.
+	- If setting up as a Raspberry Pi terminal/server, included the option
+		to make the terminal a wireless access point if it connects to an
+		ethernet network.
+
+1.3.1 - 2022-05-11
+	- Updated installation scripts and instructions to reflect changes in
+		Raspberry Pi OS Release 2022-04-04.
+		
+1.3.2 - 2022-08-08
+	- Fixed typo in dbadmin.php that prevented adding new When Discovered
+		items.
+	- Fixed bug in create.php that prevented the page from working.
+	- Fixed bug in config.php that prevented banners from being modified.
+	- Fixed bug where action_by and action_reason were not preselected for
+		subsequent searches in search.php.
+	- Fixed bug in about.php and gpl.php that still used old $mts_db
+		database handle.
+	- Removed the server session directory option in config.php
+		Miscellaneous settings. For this to make sense, you'd have to have
+		shell access to the server and if that's the case, you'd be able
+		to make the necessary database changes as well.
+	- Fixed opendrs-initial.sql to make the default banner colors match
+		the ones in common.php.
+	- Created changelog.php for use by the "changes" link on the About
+		page so kiosk terminal users don't get dead-ended in the CHANGELOG
+		text file with no way to get back to the app.
+	- Extensive code cleanups/updates in all php files to make application
+		compatible with php8 and eliminate php warnings in apache2 error
+		log file.
+	- For Raspberry Pi:
+		- Updated server-setup.sh to attempt to install the php-mysqli package
+			for compatibility with php8.
+		- Chromium browser will use the printer designated as the local
+			default if it is selected as such in the Cups printer
+			configuration.
--- a/distfiles/about.php
+++ b/distfiles/about.php
@@ -2,15 +2,20 @@
 /*
    about.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to index.php on cancel button press
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
    header("Location:index.php");
@@ -21,7 +26,6 @@ if ($_REQUEST['cancel']) {
 if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming
@@ -31,7 +35,7 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
+// extract incoming array keys into variables


 // define local functions
@@ -42,14 +46,12 @@ $appname=APP_NAME;
 $drs_version=DRS_VERSION;

 if ($print=="Printer Friendly") {
-    $sbcolor=P_SIDEBAR_COLOR;
    $mbgcolor=P_MENUBG_COLOR;
 } else {
-    $sbcolor=SIDEBAR_COLOR;
    $mbgcolor=MENUBG_COLOR;
 }

-$role=dblookup($mts_db,"users","id","role",$userid);
+$role=dblookup($drs_db,"users","id","role",$userid);

 framework("begin","$appname","About OpenDRS",$print);

@@ -78,14 +80,14 @@ echo "
 OpenDRS $drs_version Discrepancy Reporting System
 </h3><br>
 <p>This program is licensed under the terms of the <a href=\"gpl.php\">GNU General Public License</a>. Click on the link
-or see the LICENSE file in the distribution to read it. OpenDRS is Copyright (C) 2018 by Rod Wright.
+or see the LICENSE file in the distribution to read it. OpenDRS is Copyright (C) 2022 by Rod Wright.
 </p>
 <p>
 OpenDRS is a simple online maintenance tracking/discrepancy reporting application. It allows anyone with a web browser to create ,
 view, and search writeups. The look and feel of the OpenDRS pages are easily changed. 
 Settings that affect all users can be changed in the Admin Functions menu. User specific settings can be changed in the 
 My Profile menu. No browser specific HTML is used in OpenDRS, so it should be useable in any browser, and it has been 
-tested using Google Chrome, Mozilla Firefox and Microsoft Internet Explorer.
+tested using Google Chrome, Mozilla Firefox, Microsoft Internet Explorer, and Microsoft Edge.
 </p>
 <p>
 OpenDRS is highly flexible. Instructions are included in the distribution for creating a user terminal with a Raspberry Pi. OpenDRS can be hosted on a 
@@ -93,7 +95,7 @@ centralized server, accessed by networked PCs and/or Raspberry Pi terminals. It
 terminal as a non-networked standalone system or in a small network of Raspberry Pi terminals.
 </p>
 <p>
-To read about the <a href=\"CHANGELOG\" >changes</a> in this latest version of OpenDRS, click on the link or see the CHANGELOG file in the distribution.
+To read about the <a href=\"changelog.php\" >changes</a> in this latest version of OpenDRS, click on the link or see the CHANGELOG file in the distribution.
 </p>

 <p>Several pieces of Open Source software make OpenDRS possible.
--- a/distfiles/changelog.php
+++ b/distfiles/changelog.php
@@ -0,0 +1,92 @@
+<?php
+/*
+    changelog.php
+    OpenMTS Online Maintenance Tracking System
+    Copyright (C) 2022  Rod Wright
+
+    SPDX-License-Identifier: GPL-2.0
+*/
+
+include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}
+
+// redirect to search.php on cancel button press
+if (array_key_exists('cancel',$_REQUEST)) {
+    header("Cache-Control:no-cache, must-revalidate");
+    header("Pragma:no-cache");
+    header("Location:search.php");
+    exit();
+}
+
+// import session variables
+if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];
+
+// import incoming arrays
+if ($print) {
+    // if printer friendly was clicked, values will be passed in serialized
+    // form as "all_parameters" so we need to load those into $incoming
+    $incoming=unserialize($_REQUEST['all_parameters']);
+} else {
+    // copy $_REQUEST to $incoming 
+    $incoming=arrayCopy($_REQUEST);
+}
+
+// extract incoming array keys into variables
+
+
+// define local functions
+
+
+// assign variables from constants
+$appname=APP_NAME;
+
+if ($print) {
+    $mbgcolor=P_MENUBG_COLOR;
+} else {
+    $mbgcolor=MENUBG_COLOR;
+}
+
+$role=dblookup($drs_db,"users","id","role",$userid);
+
+framework("begin","$appname","OpenDRS Change Log",$print);
+
+//echo "_REQUEST array <br>";
+//var_dump($_REQUEST);
+//echo "<br><hr> incoming array <br>";
+//var_dump($incoming);
+
+// ******** begin database manipulation ********
+
+
+// ******** end database manipulation ********
+
+pagetable("begin");
+if (!$print) {
+    pageblock("left","begin");
+    sidemenu();
+    pageblock("left","end");
+}
+pageblock("right","begin");
+banner($print);
+echo "<br>";
+
+echo "
+<pre>
+";
+echo file_get_contents("CHANGELOG");
+echo "
+</pre>
+";
+
+echo "<br>";
+banner($print);
+pageblock("right","end");
+pagetable("end");
+
+framework("end","","",$print);
+
+?>
--- a/distfiles/common.php
+++ b/distfiles/common.php
@@ -2,7 +2,7 @@
 /*
    common.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */
@@ -458,14 +458,19 @@ function banner($print) {
    }
 }

-function dblookup($dbhandle,$table,$in_field,$out_field,$in_data) {
+function dblookup($drs_db,$table,$in_field,$out_field,$in_data) {
    // look up a single field in a database given a value for a single field
-    $out_data=mysqli_fetch_row(mysqli_query($dbhandle,"select $out_field from $table where $in_field=\"$in_data\""));
+    $lookup_result=(mysqli_query($drs_db,"select $out_field from $table where $in_field=\"$in_data\""));
+    if (mysqli_num_rows($lookup_result) > 0) {
+		$out_data=mysqli_fetch_row($lookup_result);
 		return($out_data[0]);
+	} else {
+		return NULL;
+	}
 }

 function arrayCopy( array $array ) {
-        $result = array();
+        $result=[];
        foreach( $array as $key => $val ) {
            if( is_array( $val ) ) {
                $result[$key] = arrayCopy( $val );
@@ -494,7 +499,7 @@ function validate_password($pass,$passconf) {
    // first element is true if passwords match, false if not
    // second element is true if passwords meet complexity requirements, false if not
    
-    $results=array();
+    $results=[];

    // check for match
    if ($pass==$passconf) {
@@ -595,8 +600,10 @@ function displaywriteup($id) {
        if ($group_count == 1) {
            $group_ind="<a href=\"groups.php?group=$member_group\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"$imgtitle\"></a></div>";
        } else {
-            $group_ind="<a href=\"groups.php\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"View writeup groups\"></a></div>";
+            $group_ind="<a href=\"writeupdetail.php?id={$writeupdata['id']}\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"Member of $group_count groups. Click here to view.\"></a></div>";
        }
+    } else {
+		$group_ind=NULL;
 	}
    echo "
    <table border=\"2\" width=\"100%\"><tr><td>
@@ -667,20 +674,29 @@ function format_message($msgtype,$msgtxt) {
 function getsetting($setting_name,$user_id) {
    // get the value of a setting for a user
    global $drs_db;
-    $confvalue=mysqli_fetch_assoc(mysqli_query($drs_db,"select id,value from config where name=\"$setting_name\""))['value'];
-    $uservalue=mysqli_fetch_assoc(mysqli_query($drs_db,"select value from profile where name=\"$setting_name\" and user=\"$user_id\""))['value'];
+    $confqry=mysqli_query($drs_db,"select id,value from config where name=\"$setting_name\"");
+    $confvalue=mysqli_fetch_assoc($confqry)['value'];
+    $userqry=mysqli_query($drs_db,"select value from profile where name=\"$setting_name\" and user=\"$user_id\"");
+    if (mysqli_num_rows($userqry) > 0) {
+	    $uservalue=mysqli_fetch_assoc($userqry)['value'];
 	    if ($uservalue) {
 	        return $uservalue;
 	    } else {
 	        return $confvalue;
 	    }
+	} else {
+		return $confvalue;
+	}
 }

 function putsetting($setting_name,$setting_value,$user_id) {
    // set the value of a setting for a tech
    global $drs_db;
-    $confvalue=mysqli_fetch_assoc(mysqli_query($drs_db,"select value from config where name=\"$setting_name\""))['value'];
-    $uservalue=mysqli_fetch_assoc(mysqli_query($drs_db,"select value from profile where name=\"$setting_name\" and user=\"$user_id\""))['value'];
+    $confqry=mysqli_query($drs_db,"select value from config where name=\"$setting_name\"");
+    $confvalue=mysqli_fetch_assoc($confqry)['value'];
+    $userqry=mysqli_query($drs_db,"select value from profile where name=\"$setting_name\" and user=\"$user_id\"");
+    if (mysqli_num_rows($userqry) > 0) {
+	    $uservalue=mysqli_fetch_assoc($userqry)['value'];
 	    if ($setting_value==$confvalue) {
 	        mysqli_query($drs_db,"delete from profile where user=\"$user_id\" and name=\"$setting_name\"");
 	    } else {
@@ -690,10 +706,19 @@ function putsetting($setting_name,$setting_value,$user_id) {
 	            mysqli_query($drs_db,"insert into profile(user,name,value) values(\"$user_id\",\"$setting_name\",\"$setting_value\")");
 	        }
 	    }
+	} else {
+		mysqli_query($drs_db,"insert into profile(user,name,value) values(\"$user_id\",\"$setting_name\",\"$setting_value\")");
+	}
 }

-function group_table($groupid,$role=false,$mode="view",$selection="none",$expanded=false) {
+function group_detail($groupid,$role=false,$mode="view",$selection="none") {
    // display a table for a single group
+	
+	// groupid is the group for which detail is to be shown
+	// role is true if user is logged in, false if not.
+	// mode is "select" if selection boxes are to be displayed, "view" if not.
+	// selection is "all" or "none"
+    
    // grab some important global variables
    global $device_term;
    global $discovered_term, $discovered_term_short, $disc_drop_data;
@@ -708,13 +733,6 @@ function group_table($groupid,$role=false,$mode="view",$selection="none",$expand
    } elseif ($selection == "none") {
        $sel_flag="";
    }
-    if ($expanded) {
-        echo "
-        <a href=\"groups.php\" style=\"text-decoration:none\">
-        <img src=\"icons/minus-white.png\" alt=\"Unexpand group\">
-        </a>
-        ";
-    }
    $groupname=dblookup($drs_db,"groups","id","name",$groupid);
    if ($groupname == "") {
        echo "<b>Group ID: &nbsp;$groupid";
--- a/distfiles/config.php
+++ b/distfiles/config.php
@@ -2,15 +2,20 @@
 /*
    config.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to index.php on cancel button press
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
    header("Location:index.php");
@@ -30,7 +35,6 @@ if ($role != ADMIN) {
 }

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming[]
@@ -40,45 +44,55 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-$update_display=$incoming['update_display'];
-$display_appname=$incoming['display_appname'];
-$display_banner=$incoming['display_banner'];
-$display_footer=$incoming['display_footer'];
-$display_funchelp=$incoming['display_funchelp'];
-$display_device_term=$incoming['display_device_term'];
-$display_discovered_term=$incoming['display_discovered_term'];
-$display_discovered_term_short=$incoming['display_discovered_term_short'];
-$display_disc_drop_data=$incoming['display_disc_drop_data'];
-$display_functional_term=$incoming['display_functional_term'];
-$display_functional_term_short=$incoming['display_functional_term_short'];
-$display_functional_yes=$incoming['display_functional_yes'];
-$display_functional_no=$incoming['display_functional_no'];
-$display_functional_yes_short=$incoming['display_functional_yes_short'];
-$display_functional_no_short=$incoming['display_functional_no_short'];
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+ * possible keys are:
+ * update_display
+ * display_appname
+ * display_banner
+ * display_footer
+ * display_funchelp
+ * display_device_term
+ * display_discovered_term
+ * display_discovered_term_short
+ * display_disc_drop_data
+ * display_functional_term
+ * display_functional_term_short
+ * display_functional_yes
+ * display_functional_no
+ * display_functional_yes_short
+ * display_functional_no_short
+ * update_colors
+ * reset_colors
+ * newbgc
+ * newmbgc
+ * newtc
+ * newlc
+ * newvlc
+ * newhc
+ * edit_banner
+ * add_banner
+ * update_banner
+ * delete_banner
+ * bnrid
+ * bnrname
+ * bnrcolor
+ * bnrtxtcolor
+ * update_misc
+ * sessttl
+ * logoutall
+ */

-$update_colors=$incoming['update_colors'];
-$reset_colors=$incoming['reset_colors'];
-$newbgc=$incoming['newbgc'];
-$newmbgc=$incoming['newmbgc'];
-$newtc=$incoming['newtc'];
-$newlc=$incoming['newlc'];
-$newvlc=$incoming['newvlc'];
-$newhc=$incoming['newhc'];
-
-$edit_banner=$incoming['edit_banner'];
-$add_banner=$incoming['add_banner'];
-$update_banner=$incoming['update_banner'];
-$delete_banner=$incoming['delete_banner'];
-$bnrid=$incoming['bnrid'];
-$bnrname=$incoming['bnrname'];
-$bnrcolor=$incoming['bnrcolor'];
-$bnrtxtcolor=$incoming['bnrtxtcolor'];
-
-$update_misc=$incoming['update_misc'];
-$sessttl=$incoming['sessttl'];
-$sessdir=$incoming['sessdir'];
-$logoutall=$incoming['logoutall'];
+if (!isset($update_display)) $update_display=false;
+if (!isset($update_colors)) $update_colors=false;
+if (!isset($reset_colors)) $reset_colors=false;
+if (!isset($add_banner)) $add_banner=false;
+if (!isset($edit_banner)) $edit_banner=false;
+if (!isset($update_banner)) $update_banner=false;
+if (!isset($delete_banner)) $delete_banner=false;
+if (!isset($update_misc)) $update_misc=false;
+if (!isset($logoutall)) $logoutall=false;

 // assign variables from constants
 $appname=APP_NAME;
@@ -97,6 +111,8 @@ framework("begin","$appname","Configuration",$print);
 //var_dump($incoming);

 // ******** begin database manipulation ********
+$nameunique_err=$namesuppld_err=$ttlsuppld_err=$dirsuppld_err=false;
+
 if ($update_display) {
    // remove html tags from footer_message and sanitize
    $display_footer=strip_tags($display_footer);
@@ -174,6 +190,7 @@ if ($add_banner) {
    // test for name supplied
    if (strlen(trim($bnrname))) {
        $namesuppld=true;
+        $namesuppld_err=false;
    } else {
        $namesuppld=false;
        $namesuppld_err=true;
@@ -184,6 +201,7 @@ if ($add_banner) {
        $nameunique_err=true;
    } else {
        $nameunique=true;
+        $nameunique_err=false;
    }
    if ($namesuppld && $nameunique) {
        // sanitize banner name
@@ -204,17 +222,19 @@ if ($edit_banner) {
        // test for name supplied
        if (strlen(trim($bnrname))) {
            $namesuppld=true;
+            $namesuppld_err=false;
        } else {
            $namesuppld=false;
            $namesuppld_err=true;
        }
        // test for name unique
-        if (mysqli_num_rows(mysqli_query($db,"select bannerid from banners where bannername=\"$bnrname\" and bannerid!=\"$bnrid\""))) {
+        if (mysqli_num_rows(mysqli_query($drs_db,"select bannerid from banners where bannername=\"$bnrname\" and bannerid!=\"$bnrid\""))) {
            if (mysqli_num_rows(mysqli_query($drs_db,"select bannerid from banners where bannername=\"$bnrname\""))) {
                $nameunique=false;
                $nameunique_err=true;
            } else {
                $nameunique=true;
+                $nameunique_err=false;
            }
        } else {
            $nameunique=true;
@@ -246,20 +266,8 @@ if ($update_misc) {
        $ttlsuppld=false;
        $ttlsuppld_err=true;
    }
-    // test for sessdir supplied
-    if (strlen(trim($sessdir))) {
-        $dirsuppld=true;
-    } else {
-        $dirsuppld=false;
-        $dirsuppld_err=true;
-    }
-    if ($ttlsuppld && $dirsuppld) {
+    if ($ttlsuppld) {
        mysqli_query($drs_db,"update config set value=\"$sessttl\" where name=\"session_ttl_days\"");
-        if ($ostype == 'WIN') {
-            mysqli_query($drs_db,"update config set value=\"$sessdir\" where name=\"win_server_session_dir\"");
-        } else {
-            mysqli_query($drs_db,"update config set value=\"$sessdir\" where name=\"unix_server_session_dir\"");
-        }
    }
 }

@@ -536,17 +544,10 @@ echo "
 <form method=\"post\" action=\"config.php#miscellaneous\">
 ";
 if ($ttlsuppld_err) format_message(1,"Session expiration time cannot be blank.");
-if ($dirsuppld_err) format_message(1,"Server session file directory cannot be blank.");
 $curttl=mysqli_fetch_row(mysqli_query($drs_db,"select value from config where name=\"session_ttl_days\""))[0];
-if ($ostype == 'WIN') {
-    $curssdir=mysqli_fetch_row(mysqli_query($drs_db,"select value from config where name=\"win_server_session_dir\""))[0];
-} else {
-    $curssdir=mysqli_fetch_row(mysqli_query($drs_db,"select value from config where name=\"unix_server_session_dir\""))[0];
-}
 echo "
 <font size=\"+1\"><b>Miscellaneous Configuration Parameters</b></font><br><br><br><br>
 Session expiration time (users will have to log in again after this long) : &nbsp;<input type=\"text\" name=\"sessttl\" size=\"3\" value=\"$curttl\"> days<br><br>
-Server session file directory (must be writable by the web server process) : <br><input type=\"text\" name=\"sessdir\" size=\"40\" value=\"$curssdir\"><br><br>
 Force logout of all users &nbsp;<input type=\"checkbox\" name=\"logoutall\"><br><br><br><br>
 <input type=\"submit\" name=\"update_misc\" value=\"Update Options\">&nbsp;&nbsp;&nbsp;&nbsp;
 <input type=\"submit\" name=\"reset\" value=\"Reset\"><br>
--- a/distfiles/create.php
+++ b/distfiles/create.php
@@ -2,15 +2,20 @@
 /*
    create.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to writeups.php on change cancel
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
    header("Location:writeups.php");
@@ -18,10 +23,14 @@ if ($_REQUEST['cancel']) {
 }

 // import session variables
-if (isset($_SESSION['personid'])) $personid=$_SESSION['personid'];
+if (isset($_SESSION['userid'])) {
+	$userid=$_SESSION['userid'];
+} else {
+	$userid=NULL;
+}
+

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming[]
@@ -31,28 +40,40 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-$create=$incoming['create'];
-$device=$incoming['device'];
-$discovered=$incoming['discovered'];
-$functional=$incoming['functional'];
-$reported_by=$incoming['reported_by'];
-$report_date=$incoming['report_date'];
-$report_time=$incoming['report_time'];
-$subsystem=$incoming['subsystem'];
-$discrepancy_text=$incoming['discrepancy_text'];
-$status=$incoming['status'];
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+ * possible keys are:
+ * create
+ * device
+ * discovered
+ * functional
+ * reported_by
+ * report_date
+ * report_time
+ * subsystem
+ * discrepancy_text
+ * status
+ */
+
+if (!isset($device)) $device=NULL;
+if (!isset($discovered)) $discovered=NULL;
+if (!isset($reported_by)) $reported_by=NULL;
+if (!isset($discrepancy_text)) $discrepancy_text=NULL;
+if (!isset($functional)) $functional=NULL;
+if (!isset($subsystem)) $subsystem=NULL;
+

 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
    $mbgcolor=MENUBG_COLOR;
 }

-$role=dblookup($drs_db,"persons","id","role",$personid);
+$role=dblookup($drs_db,"users","id","role",$userid);

 framework("begin","$appname","New Writeup",$print);

@@ -66,17 +87,17 @@ framework("begin","$appname","New Writeup",$print);
 // determine today's date and make it the default 
 $today=date("Y-m-d");
 $now=date("H:i:s");
-if (!$report_date || $report_date=="automatic") $report_date=$today;
-if (!$report_time || $report_time=="automatic") $report_time=$now;
+if (!isset($report_date) || $report_date=="automatic") $report_date=$today;
+if (!isset($report_time) || $report_time=="automatic") $report_time=$now;

-if ($create) {    
+if (isset($create)) {    
    // add the entry if create is pressed   
-    if ($discrepancy_text && $reported_by && $device && $subsystem && $discovered) {
+    if ($discrepancy_text!=NULL && $reported_by!=NULL && $device!=NULL && $subsystem!=NULL && $discovered!=NULL) {
        // sanitize and fix blank date and time
        $report_date=mysqli_real_escape_string($drs_db,$report_date);
        $report_time=mysqli_real_escape_string($drs_db,$report_time);
-        if (!$report_date) $report_date=$today;
-        if (!$report_time) $report_time=$now;
+        if (!isset($report_date)) $report_date=$today;
+        if (!isset($report_time)) $report_time=$now;
        
        // remove html tags from discrepancy text and sanitize
        $discrepancy_text=strip_tags($discrepancy_text);
@@ -101,33 +122,33 @@ pageblock("right","begin");
 banner($print);
 echo "<br>";
 // display the form
-if ($create) {
-    if ($discrepancy_text && $reported_by) {
+if (isset($create)) {
+    if ($discrepancy_text!=NULL && $reported_by!=NULL) {
        format_message(0,"<strong>Writeup created.</strong> You may create another writeup or <a href=\"writeups.php\">return to Open Writeups page.</a>");
-        $preserve=FALSE;
+        $preserve=false;
    }
-    if (!$device) {
+    if ($device==NULL) {
        format_message(1,"You didn't select a $device_term. Please try again.");
-        $preserve=TRUE;
+        $preserve=true;
    }
-    if (!$subsystem) {
+    if ($subsystem==NULL) {
        format_message(1,"You didn't select a subsystem. Please try again.");
-        $preserve=TRUE;
+        $preserve=true;
    }
-    if (!$discovered) {
+    if ($discovered==NULL) {
        format_message(1,"You didn't select a $discovered_term. Please try again.");
-        $preserve=TRUE;
+        $preserve=true;
    }
-    if (!$discrepancy_text) {
+    if ($discrepancy_text==NULL) {
        format_message(1,"You didn't enter any discrepancy text. Please try again.");
-        $preserve=TRUE;
+        $preserve=true;
    }
-    if (!$reported_by) {
+    if ($reported_by==NULL) {
        format_message(1,"You didn't enter your name in the Reported by: block. Please try again.");
-        $preserve=TRUE;
+        $preserve=true;
    }
 } else {
-    $preserve=FALSE;
+    $preserve=false;
 }

 echo "
@@ -135,9 +156,6 @@ echo "
 ";

 // start writeup entry section
-if ($status==1) $statusind="<b><font color=\"#FF0000\">OPEN</font></b>";
-if ($status==2) $statusind="<b><font color=\"#008000\">CLSD</font></b>";
-if ($status==3) $statusind="<b><font color=\"#FFFF00\">DFRD</font></b>";

 echo "
 <table border=\"0\" cellpadding=\"5\">
@@ -185,7 +203,7 @@ if ($disc_drop_data=="Name") {
 }
 $drow=mysqli_query($drs_db,"select * from discovered where active is true order by whendiscoveredname asc");
 while ($ditem=mysqli_fetch_assoc($drow)) {
-    if ($discoverd==$ditem["id"] && $preserve) {
+    if ($discovered==$ditem["id"] && $preserve) {
        printf("<option value=\"%s\" title=\"%s\" selected>%s</option>",$ditem["id"],$ditem["$discddtitle"],$ditem["$discddtext"]);
    } else {
        printf("<option value=\"%s\" title=\"%s\">%s</option>",$ditem["id"],$ditem["$discddtitle"],$ditem["$discddtext"]);
--- a/distfiles/dbadmin.php
+++ b/distfiles/dbadmin.php
@@ -2,15 +2,19 @@
 /*
    dbadmin.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
-
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}
 // redirect to index.php on cancel button press
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
    header("Location:index.php");
@@ -30,7 +34,6 @@ if ($role != ADMIN) {
 }

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming[]
@@ -40,53 +43,85 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-$edit_user=$incoming['edit_user'];
-$add_user=$incoming['add_user'];
-$update_user=$incoming['update_user'];
-$delete_user=$incoming['delete_user'];
-$user_id=$incoming['user_id'];
-$user_fname=$incoming['user_fname'];
-$user_lname=$incoming['user_lname'];
-$user_login=$incoming['user_login'];
-$user_pass=$incoming['user_pass'];
-$user_passconf=$incoming['user_passconf'];
-$user_role=$incoming['user_role'];
-$user_active=$incoming['user_active'];
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+* possible keys are:
+* edit_user
+* add_user
+* update_user
+* delete_user
+* user_id
+* user_fname
+* user_lname
+* user_login
+* user_pass
+* user_passconf
+* user_role
+* user_active
+* edit_device
+* add_device
+* update_device
+* delete_device
+* device_id
+* device_name
+* device_active
+* edit_subsystem
+* add_subsystem
+* update_subsystem
+* delete_subsystem
+* subsystem_id
+* subsystem_name
+* subsystem_desc
+* subsystem_active
+* edit_reason
+* add_reason
+* update_reason
+* delete_reason
+* reason_id
+* reason_text
+* reason_active
+* edit_discovered
+* add_discovered
+* update_discovered
+* delete_discovered
+* discovered_id
+* discovered_name
+* discovered_desc
+* discovered_active
+*/

-$edit_device=$incoming['edit_device'];
-$add_device=$incoming['add_device'];
-$update_device=$incoming['update_device'];
-$delete_device=$incoming['delete_device'];
-$device_id=$incoming['device_id'];
-$device_name=$incoming['device_name'];
-$device_active=$incoming['device_active'];
-
-$edit_subsystem=$incoming['edit_subsystem'];
-$add_subsystem=$incoming['add_subsystem'];
-$update_subsystem=$incoming['update_subsystem'];
-$delete_subsystem=$incoming['delete_subsystem'];
-$subsystem_id=$incoming['subsystem_id'];
-$subsystem_name=$incoming['subsystem_name'];
-$subsystem_desc=$incoming['subsystem_desc'];
-$subsystem_active=$incoming['subsystem_active'];
-
-$edit_reason=$incoming['edit_reason'];
-$add_reason=$incoming['add_reason'];
-$update_reason=$incoming['update_reason'];
-$delete_reason=$incoming['delete_reason'];
-$reason_id=$incoming['reason_id'];
-$reason_text=$incoming['reason_text'];
-$reason_active=$incoming['reason_active'];
-
-$edit_discovered=$incoming['edit_discovered'];
-$add_discovered=$incoming['add_discovered'];
-$update_discovered=$incoming['update_discovered'];
-$delete_discovered=$incoming['delete_discovered'];
-$discovered_id=$incoming['discovered_id'];
-$discovered_name=$incoming['discovered_name'];
-$discovered_desc=$incoming['discovered_desc'];
-$discovered_active=$incoming['discovered_active'];
+if (!isset($edit_user)) $edit_user=false;
+if (!isset($add_user)) $add_user=false;
+if (!isset($update_user)) $update_user=false;
+if (!isset($delete_user)) $delete_user=false;
+if (!isset($edit_device)) $edit_device=false;
+if (!isset($add_device)) $add_device=false;
+if (!isset($update_device)) $update_device=false;
+if (!isset($delete_device)) $delete_device=false;
+if (!isset($edit_subsystem)) $edit_subsystem=false;
+if (!isset($add_subsystem)) $add_subsystem=false;
+if (!isset($update_subsystem)) $update_subsystem=false;
+if (!isset($delete_subsystem)) $delete_subsystem=false;
+if (!isset($edit_reason)) $edit_reason=false;
+if (!isset($add_reason)) $add_reason=false;
+if (!isset($update_reason)) $update_reason=false;
+if (!isset($delete_reason)) $delete_reason=false;
+if (!isset($edit_discovered)) $edit_discovered=false;
+if (!isset($add_discovered)) $add_discovered=false;
+if (!isset($update_discovered)) $update_discovered=false;
+if (!isset($delete_discovered)) $delete_discovered=false;
+if (!isset($user_fname)) $user_fname=NULL;
+if (!isset($user_lname)) $user_lname=NULL;
+if (!isset($user_login)) $user_login=NULL;
+if (!isset($user_pass)) $user_pass=NULL;
+if (!isset($user_passconf)) $user_passconf=NULL;
+if (!isset($device_name)) $device_name=NULL;
+if (!isset($subsystem_name)) $subsystem_name=NULL;
+if (!isset($subsystem_desc)) $subsystem_desc=NULL;
+if (!isset($reason_text)) $reason_text=NULL;
+if (!isset($discovered_name)) $discovered_name=NULL;
+if (!isset($discovered_desc)) $discovered_desc=NULL;

 // define local functions

@@ -94,7 +129,7 @@ $discovered_active=$incoming['discovered_active'];
 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
    $mbgcolor=MENUBG_COLOR;
@@ -110,6 +145,11 @@ framework("begin","$appname","Database Administration",$print);
 // ******** begin database manipulation ********

 // users-------------------------------------
+$usernameunique_err=$fnamesuppld_err=$lnamesuppld_err=false;
+$loginsuppld_err=$loginunique_err=$passcomplex_err=$passmatch_err=false;
+$userhaswriteups_err=false;
+$user_add_fail=false;
+
 if ($add_user) {
    // do error checking
    // remove html tags from user name
@@ -119,6 +159,7 @@ if ($add_user) {
    // test for first name supplied
    if (strlen(trim($user_fname))) {
        $fnamesuppld=true;
+        $fnamesuppld_err=false;
    } else {
        $fnamesuppld=false;
        $fnamesuppld_err=true;
@@ -126,6 +167,7 @@ if ($add_user) {
    // test for last name supplied
    if (strlen(trim($user_lname))) {
        $lnamesuppld=true;
+        $lnamesuppld_err=false;
    } else {
        $lnamesuppld=false;
        $lnamesuppld_err=true;
@@ -136,10 +178,12 @@ if ($add_user) {
        $usernameunique_err=true;
    } else {
        $usernameunique=true;
+        $usernameunique_err=false;
    }
    // test for login supplied
    if (strlen(trim($user_login))) {
        $loginsuppld=true;
+        $loginsuppld_err=false;
    } else {
        $loginsuppld=false;
        $loginsuppld_err=true;
@@ -150,27 +194,30 @@ if ($add_user) {
        $loginunique_err=true;
    } else {
        $loginunique=true;
+        $loginunique_err=false;
    }
    // test passwords
    $passresults=validate_password($user_pass,$user_passconf);
    if ($passresults['match']) {
        $passmatch=true;
+        $passmatch_err=false;
    } else {
        $passmatch=false;
        $passmatch_err=true;
    }
    if ($passresults['complex']) {
        $passcomplex=true;
+        $passcomplex_err=false;
    } else {
        $passcomplex=false;
        $passcomplex_err=true;
    }
    
    // set role
-    if (!$user_role) $user_role=USER;
+    if (!isset($user_role)) $user_role=USER;
    
    // set active status
-    if (!$user_active) $user_active=0;
+    if (!isset($user_active)) $user_active=0;
        
    if ($fnamesuppld && $lnamesuppld && $usernameunique && $loginsuppld && $loginunique && $passcomplex && $passmatch) {
        // sanitize first name, last name, login
@@ -181,6 +228,7 @@ if ($add_user) {
        $passhash=password_hash($user_pass,PASSWORD_DEFAULT);
        // modify the table
        mysqli_query($drs_db,"insert into users(firstname,lastname,login,password_hash,role,active) values(\"$clean_fname\",\"$clean_lname\",\"$clean_login\",\"$passhash\",\"$user_role\",\"$user_active\")");
+        $user_add_fail=false;
    } else {
        $user_add_fail=true;
    }
@@ -194,6 +242,7 @@ if ($edit_user) {
            $userhaswriteups_err=true;
        } else {
            $userhaswriteups=false;
+            $userhaswriteups_err=false;
        }
        // if none, then remove from db
        if (!$userhaswriteups) mysqli_query($drs_db,"delete from users where id=\"$user_id\"");
@@ -207,6 +256,7 @@ if ($edit_user) {
        // test for first name supplied
        if (strlen(trim($user_fname))) {
            $fnamesuppld=true;
+            $fnamesuppld_err=false;
        } else {
            $fnamesuppld=false;
            $fnamesuppld_err=true;
@@ -214,6 +264,7 @@ if ($edit_user) {
        // test for last name supplied
        if (strlen(trim($user_lname))) {
            $lnamesuppld=true;
+            $lnamesuppld_err=false;
        } else {
            $lnamesuppld=false;
            $lnamesuppld_err=true;
@@ -225,13 +276,16 @@ if ($edit_user) {
 	            $nameunique_err=true;
            } else {
                $nameunique=true;
+                $nameunique_err=false;
            }
        } else {
            $nameunique=true;
+            $nameunique_err=false;
        }
        // test for login supplied
        if (strlen(trim($user_login))) {
            $loginsuppld=true;
+            $loginsuppld_err=false;
        } else {
            $loginsuppld=false;
            $loginsuppld_err=true;
@@ -243,9 +297,11 @@ if ($edit_user) {
                $loginunique_err=true;
            } else {
                $loginunique=true;
+                $loginunique_err=false;
            }
        } else {
            $loginunique=true;
+            $loginunique_err=false;
        }
        // sanitize first name, last name, login
        $clean_fname=mysqli_real_escape_string($drs_db,$user_fname);
@@ -253,22 +309,24 @@ if ($edit_user) {
        $clean_login=mysqli_real_escape_string($drs_db,$user_login);
        
        // set role
-        if (!$user_role) $user_role=USER;
+        if (!isset($user_role)) $user_role=USER;
        
        // set active status
-        if (!$user_active) $user_active=0;
+        if (!isset($user_active)) $user_active=0;
        
        if ($user_pass!="password_is_unchanged") {
            // test passwords
            $passresults=validate_password($user_pass,$user_passconf);
            if ($passresults['match']) {
                $passmatch=true;
+                $passmatch_err=false;
            } else {
                $passmatch=false;
                $passmatch_err=true;
            }
            if ($passresults['complex']) {
                $passcomplex=true;
+                $passcomplex_err=false;
            } else {
                $passcomplex=false;
                $passcomplex_err=true;
@@ -290,6 +348,10 @@ if ($edit_user) {
 }

 // devices-------------------------------
+$devicenameunique_err=$devicenamesuppld_err=false;
+$devicehaswriteups_err=false;
+$device_add_fail=false;
+
 if ($add_device) {
    // do error checking
    // remove html tags from device name
@@ -297,6 +359,7 @@ if ($add_device) {
    // test for device name supplied
    if (strlen(trim($device_name))) {
        $devicenamesuppld=true;
+        $devicenamesuppld_err=false;
    } else {
        $devicenamesuppld=false;
        $devicenamesuppld_err=true;
@@ -307,16 +370,18 @@ if ($add_device) {
        $devicenameunique_err=true;
    } else {
        $devicenameunique=true;
+        $devicenameunique_err=false;
    }
    
    // set active status
-    if (!$device_active) $device_active=0;
+    if (!isset($device_active)) $device_active=0;
    
    if ($devicenamesuppld && $devicenameunique) {
        // sanitize device name
        $clean_devicename=mysqli_real_escape_string($drs_db,$device_name);
        // modify the table
        mysqli_query($drs_db,"insert into devices(name,active) values(\"$clean_devicename\",\"$device_active\")");
+        $device_add_fail=false;
    } else {
        $device_add_fail=true;
    }
@@ -329,6 +394,7 @@ if ($edit_device) {
            $devicehaswriteups_err=true;
        } else {
            $devicehaswriteups=false;
+            $devicehaswriteups_err=false;
        }
        // if none, then remove from db
        if (!$devicehaswriteups) mysqli_query($drs_db,"delete from devices where id=\"$device_id\"");
@@ -340,6 +406,7 @@ if ($edit_device) {
        // test for device name supplied
        if (strlen(trim($device_name))) {
            $devicenamesuppld=true;
+            $devicenamesuppld_err=false;
        } else {
            $devicenamesuppld=false;
            $devicenamesuppld_err=true;
@@ -351,13 +418,15 @@ if ($edit_device) {
 	            $devicenameunique_err=true;
            } else {
                $devicenameunique=true;
+                $devicenameunique_err=false;
            }
        } else {
            $devicenameunique=true;
+            $devicenameunique_err=false;
        }
        
        // set active status
-        if (!$user_active) $user_active=0;
+        if (!isset($device_active)) $device_active=0;
        
        // sanitize device name
        $clean_devicename=mysqli_real_escape_string($drs_db,$device_name);
@@ -370,6 +439,10 @@ if ($edit_device) {
 }

 // subsystems--------------------------------
+$ssnameunique_err=$ssnamesuppld_err=false;
+$sshaswriteups_err=false;
+$subsystem_add_fail=false;
+
 if ($add_subsystem) {
    // do error checking
    // remove html tags from subsystem name and description
@@ -378,6 +451,7 @@ if ($add_subsystem) {
    // test for subsystem name supplied
    if (strlen(trim($subsystem_name))) {
        $ssnamesuppld=true;
+        $ssnamesuppld_err=false;
    } else {
        $ssnamesuppld=false;
        $ssnamesuppld_err=true;
@@ -388,10 +462,11 @@ if ($add_subsystem) {
        $ssnameunique_err=true;
    } else {
        $ssnameunique=true;
+        $ssnameunique_err=false;
    }
    
    // set active status
-    if (!$subsystem_active) $subsystem_active=0;
+    if (!isset($subsystem_active)) $subsystem_active=0;
    
    if ($ssnamesuppld && $ssnameunique) {
        // sanitize subsystem name and description
@@ -399,6 +474,7 @@ if ($add_subsystem) {
        $clean_subsystemdesc=mysqli_real_escape_string($drs_db,$subsystem_desc);
        // modify the table
        mysqli_query($drs_db,"insert into subsystems(name,description,active) values(\"$clean_subsystemname\",\"$clean_subsystemdesc\",\"$subsystem_active\")");
+        $subsystem_add_fail=false;
    } else {
        $subsystem_add_fail=true;
    }
@@ -411,6 +487,7 @@ if ($edit_subsystem) {
            $sshaswriteups_err=true;
        } else {
            $sshaswriteups=false;
+            $sshaswriteups_err=false;
        }
        // if none, then remove from db
        if (!$sshaswriteups) mysqli_query($drs_db,"delete from subsystems where id=\"$subsystem_id\"");
@@ -423,6 +500,7 @@ if ($edit_subsystem) {
        // test for subsystem name supplied
        if (strlen(trim($subsystem_name))) {
            $ssnamesuppld=true;
+            $ssnamesuppld_err=false;
        } else {
            $ssnamesuppld=false;
            $ssnamesuppld_err=true;
@@ -434,9 +512,11 @@ if ($edit_subsystem) {
 	            $ssnameunique_err=true;
            } else {
                $ssnameunique=true;
+                $ssnameunique_err=false;
            }
        } else {
            $ssnameunique=true;
+            $ssnameunique_err=false;
        }
        // sanitize subsystem name and description
        $clean_ssname=mysqli_real_escape_string($drs_db,$subsystem_name);
@@ -450,6 +530,10 @@ if ($edit_subsystem) {
 }

 // reasons------------------------------------
+$reastextunique_err=$reastextsuppld_err=false;
+$reashaswriteups_err=false;
+$reason_add_fail=false;
+
 if ($add_reason) {
    // do error checking
    // remove html tags from reason text
@@ -457,6 +541,7 @@ if ($add_reason) {
    // test for reason text supplied
    if (strlen(trim($reason_text))) {
        $reastextsuppld=true;
+        $reastextsuppld_err=false;
    } else {
        $reastextsuppld=false;
        $reastextsuppld_err=true;
@@ -467,16 +552,18 @@ if ($add_reason) {
        $reastextunique_err=true;
    } else {
        $reastextunique=true;
+        $reastextunique_err=false;
    }
    
    // set active status
-    if (!$reason_active) $reason_active=0;
+    if (!isset($reason_active)) $reason_active=0;
    
    if ($reastextsuppld && $reastextunique) {
        // sanitize reason text
        $clean_reastext=mysqli_real_escape_string($drs_db,$reason_text);
        // modify the table
        mysqli_query($drs_db,"insert into reasons(text,active) values(\"$clean_reastext\",\"$reason_active\")");
+        $reason_add_fail=false;
    } else {
        $reason_add_fail=true;
    }
@@ -489,6 +576,7 @@ if ($edit_reason) {
            $reashaswriteups_err=true;
        } else {
            $reashaswriteups=false;
+            $reashaswriteups_err=false;
        }
        // if none, then remove from db
        if (!$reashaswriteups) mysqli_query($drs_db,"delete from reasons where id=\"$reason_id\"");
@@ -500,6 +588,7 @@ if ($edit_reason) {
        // test for reason text supplied
        if (strlen(trim($reason_text))) {
            $reastextsuppld=true;
+            $reastextsuppld_err=false;
        } else {
            $reastextsuppld=false;
            $reastextsuppld_err=true;
@@ -511,13 +600,15 @@ if ($edit_reason) {
            $reastextunique_err=true;
            } else {
                $reastextunique=true;
+                $reastextunique_err=false;
            }
        } else {
            $reastextunique=true;
+            $reastextunique_err=false;
        }
        
        // set active status
-        if (!$reason_active) $reason_active=0;
+        if (!isset($reason_active)) $reason_active=0;
        
        // sanitize reason text
        $clean_reastext=mysqli_real_escape_string($drs_db,$reason_text);
@@ -530,6 +621,10 @@ if ($edit_reason) {
 }

 // when discovered-----------------------------------
+$discnamesuppld_err=$discnameunique_err=$discdescsuppld_err=false;
+$dischaswriteups_err=false;
+$discovered_add_fail=false;
+
 if ($add_discovered) {
    // do error checking
    // remove html tags from name and description
@@ -538,6 +633,7 @@ if ($add_discovered) {
    // test for name supplied
    if (strlen(trim($discovered_name))) {
        $discnamesuppld=true;
+        $discnamesuppld_err=false;
    } else {
        $discnamesuppld=false;
        $discnamesuppld_err=true;
@@ -548,24 +644,27 @@ if ($add_discovered) {
        $discnameunique_err=true;
    } else {
        $discnameunique=true;
+        $discnameunique_err=false;
    }
    // test for description supplied
    if (strlen(trim($discovered_desc))) {
        $discdescsuppld=true;
+        $discdescsuppld_err=false;
    } else {
        $discdescsuppld=false;
        $discdescsuppld_err=true;
    }
    // test for description unique
-    if (mysqli_num_rows(mysqli_query($drs_db,"select id from description where whendiscovereddesc =\"$discovered_desc\""))) {
+    if (mysqli_num_rows(mysqli_query($drs_db,"select id from discovered where whendiscovereddesc =\"$discovered_desc\""))) {
        $discdescunique=false;
        $discdescunique_err=true;
    } else {
        $discdescunique=true;
+        $discdescunique_err=false;
    }
    
    // set active status
-    if (!$discovered_active) $discovered_active=0;
+    if (!isset($discovered_active)) $discovered_active=0;
    
    if ($discnamesuppld && $discnameunique && $discdescsuppld) {
        // sanitize name
@@ -574,6 +673,7 @@ if ($add_discovered) {
        $clean_discovered_desc=mysqli_real_escape_string($drs_db,$discovered_desc);
        // modify the table
        mysqli_query($drs_db,"insert into discovered(whendiscoveredname,whendiscovereddesc,active) values(\"$clean_discovered_name\",\"$clean_discovered_desc\",\"$discovered_active\")");
+        $discovered_add_fail=false;
    } else {
        $discovered_add_fail=true;
    }
@@ -586,6 +686,7 @@ if ($edit_discovered) {
            $dischaswriteups_err=true;
        } else {
            $dischaswriteups=false;
+            $dischaswriteups_err=false;
        }
        // if none, then remove from db
        if (!$dischaswriteups) mysqli_query($drs_db,"delete from discovered where id=\"$discovered_id\"");
@@ -598,6 +699,7 @@ if ($edit_discovered) {
 	    // test for name supplied
 	    if (strlen(trim($discovered_name))) {
 	        $discnamesuppld=true;
+	        $discnamesuppld_err=false;
 	    } else {
 	        $discnamesuppld=false;
 	        $discnamesuppld_err=true;
@@ -609,30 +711,23 @@ if ($edit_discovered) {
 		        $discnameunique_err=true;
 		    } else {
 		        $discnameunique=true;
+		        $discnameunique_err=false;
 		    }
 	    } else {
 			$discnameunique=true;
+			$discnameunique_err=false;
 		}
 	    // test for description supplied
 	    if (strlen(trim($discovered_desc))) {
 	        $discdescsuppld=true;
+	        $discdescsuppld_err=false;
 	    } else {
 	        $discdescsuppld=false;
 	        $discdescsuppld_err=true;
 	    }
-	    // test for description unique
-		if (mysqli_num_rows(mysqli_query($drs_db,"select id from discovered where whendiscovereddesc=\"$discovered_text\" and id!=\"$discovered_id\""))) {
-		    if (mysqli_num_rows(mysqli_query($drs_db,"select id from discovered where whendiscovereddesc =\"$discovered_desc\""))) {
-		        $discdescunique=false;
-		        $discdescunique_err=true;
-		    } else {
-		        $discdescunique=true;
-		    }
-		} else {
-			$discdescunique=true;
-		}
+	    
 	    // set active status
-        if (!$discovered_active) $discovered_active=0;
+        if (!isset($discovered_active)) $discovered_active=0;
        
        // sanitize name
        $clean_discovered_name=mysqli_real_escape_string($drs_db,$discovered_name);
@@ -640,7 +735,7 @@ if ($edit_discovered) {
        $clean_discovered_desc=mysqli_real_escape_string($drs_db,$discovered_desc);
        
        $updqry="update discovered set whendiscoveredname=\"$clean_discovered_name\",whendiscovereddesc=\"$clean_discovered_desc\",active=\"$discovered_active\" where id=\"$discovered_id\"";
-        if ($discnamesuppld && $discnameunique && $discdescsuppld && $discdescunique) {
+        if ($discnamesuppld && $discnameunique && $discdescsuppld) {
            // modify the table
            mysqli_query($drs_db,$updqry);
        }
@@ -707,7 +802,7 @@ if ($edit_user && !$delete_user) {
    }
 } else {
    // set form options for add
-    if (!$user_add_fail) unset($user_id,$user_fname,$user_lname,$user_login,$user_pass,$user_passconf,$user_role,$user_active);
+    if (!$user_add_fail) $user_id=$user_fname=$user_lname=$user_login=$user_pass=$user_passconf=$user_role=$user_active=NULL;
    $sectiontitle="<b><font size=\"+1\">Add New User</font></b><br><br>";
    $formtag="<form method=\"post\" action=\"dbadmin.php#users\">";
    $buttontags="
@@ -812,7 +907,7 @@ if ($edit_device && !$delete_device) {
    }
 } else {
    // set form options for add
-    if (!$device_add_fail) unset($device_id,$device_name,$device_active);
+    if (!$device_add_fail) $device_id=$device_name=$device_active=NULL;
    $sectiontitle="<b><font size=\"+1\">Add New Device</font></b><br><br>";
    $formtag="<form method=\"post\" action=\"dbadmin.php#devices\">";
    $buttontags="
@@ -889,7 +984,7 @@ if ($edit_subsystem && !$delete_subsystem) {
    }
 } else {
    // set form options for add
-    if (!$subsystem_add_fail) unset($subsystem_id,$subsystem_name,$subsystem_desc,$subsystem_active);
+    if (!$subsystem_add_fail) $subsystem_id=$subsystem_name=$subsystem_desc=$subsystem_active=NULL;
    $sectiontitle="<b><font size=\"+1\">Add New Subsystem</font></b><br><br>";
    $formtag="<form method=\"post\" action=\"dbadmin.php#subsystems\">";
    $buttontags="
@@ -969,7 +1064,7 @@ if ($edit_reason && !$delete_reason) {
    }
 } else {
    // set form options for add
-    if (!$reason_add_fail) unset($reason_id,$reason_text,$reason_active);
+    if (!$reason_add_fail) $reason_id=$reason_text=$reason_active=NULL;
    $sectiontitle="<b><font size=\"+1\">Add New Reason</font></b><br><br>";
    $formtag="<form method=\"post\" action=\"dbadmin.php#reasons\">";
    $buttontags="
@@ -1024,6 +1119,7 @@ echo "
 ";
 if ($discnamesuppld_err) format_message(1,"When Discovered name cannot be blank.");
 if ($discnameunique_err) format_message(1,"When Discovered name already exists.");
+if ($discdescsuppld_err) format_message(1,"When Discovered description cannot be blank.");
 if ($dischaswriteups_err) format_message(1,"When Discovered has writeups in the database and cannot be deleted.");

 if ($edit_discovered && !$delete_discovered) {
@@ -1047,7 +1143,7 @@ if ($edit_discovered && !$delete_discovered) {
    }
 } else {
    // set form options for add
-    if (!$discovered_add_fail) unset($discovered_id,$discovered_name,$discovered_desc,$discovered_active);
+    if (!$discovered_add_fail) $discovered_id=$discovered_name=$discovered_desc=$discovered_active=NULL;
    $sectiontitle="<b><font size=\"+1\">Add New When Discovered</font></b><br><br>";
    $formtag="<form method=\"post\" action=\"dbadmin.php#discovered\">";
    $buttontags="
--- a/distfiles/gpl.php
+++ b/distfiles/gpl.php
@@ -2,18 +2,23 @@
 /*
    gpl.php
    OpenMTS Online Maintenance Tracking System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

-// redirect to index.php on cancel button press
-if ($_REQUEST['cancel']) {
+// redirect to search.php on cancel button press
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
-    header("Location:index.php");
+    header("Location:search.php");
    exit();
 }

@@ -21,7 +26,6 @@ if ($_REQUEST['cancel']) {
 if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming
@@ -31,7 +35,7 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
+// extract incoming array keys into variables


 // define local functions
@@ -40,15 +44,13 @@ if ($print) {
 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
-    $sbcolor=P_SIDEBAR_COLOR;
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
-    $sbcolor=SIDEBAR_COLOR;
    $mbgcolor=MENUBG_COLOR;
 }

-$role=dblookup($mts_db,"users","id","role",$userid);
+$role=dblookup($drs_db,"users","id","role",$userid);

 framework("begin","$appname","GNU General Public License",$print);

--- a/distfiles/groups.php
+++ b/distfiles/groups.php
@@ -2,15 +2,20 @@
 /*
    groups.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to groups.php on cancel button press
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
    header("Location:groups.php");
@@ -18,10 +23,13 @@ if ($_REQUEST['cancel']) {
 }

 // import session variables
-if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];
+if (isset($_SESSION['userid'])) {
+	$userid=$_SESSION['userid'];
+} else {
+	$userid=NULL;
+}

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming
@@ -31,34 +39,47 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+* possible keys are:
+* action
+* save
+* targets
+* group
+* name
+* search
+* s_status
+* s_device
+* s_subsystem
+* s_discovered
+* s_report_date_start
+* s_report_date_end
+* s_report_time_start
+* s_report_time_end
+* s_discrepancy_text
+* s_reported_by
+* s_functional
+* edit_status
+* edit_action_by
+* edit_action_reason
+* edit_action_date
+* edit_action_time
+* edit_action_text
+*/

-$action=$incoming['action'];
-$save=$incoming['save'];
-$targets=$incoming['targets'];
-$group=$incoming['group'];
-$name=$incoming['name'];
-$expandgrp=$incoming['expandgrp'];
+if (!isset($action)) $action=NULL;
+if (!isset($s_discrepancy_text)) $s_discrepancy_text=NULL;
+if (!isset($s_reported_by)) $s_reported_by=NULL;
+if (!isset($edit_status)) $edit_status=NULL;
+if (!isset($edit_action_by)) $edit_action_by=NULL;
+if (!isset($edit_action_reason)) $edit_action_reason=NULL;
+if (!isset($edit_action_text)) $edit_action_text=NULL;
+if (!isset($save)) $save=false;
+if (!isset($search)) $search=false;
+if (!isset($group)) $group=NULL;
+if (!isset($name)) $name=NULL;

-$search=$incoming['search'];
-$s_status=$incoming['s_status'];
-$s_device=$incoming['s_device'];
-$s_subsystem=$incoming['s_subsystem'];
-$s_discovered=$incoming['s_discovered'];
-$s_report_date_start=$incoming['s_report_date_start'];
-$s_report_date_end=$incoming['s_report_date_end'];
-$s_report_time_start=$incoming['s_report_time_start'];
-$s_report_time_end=$incoming['s_report_time_end'];
-$s_discrepancy_text=$incoming['s_discrepancy_text'];
-$s_reported_by=$incoming['s_reported_by'];
-$s_functional=$incoming['s_functional'];
-
-$edit_status=$incoming['edit_status'];
-$edit_action_by=$incoming['edit_action_by'];
-$edit_action_reason=$incoming['edit_action_reason'];
-$edit_action_date=$incoming['edit_action_date'];
-$edit_action_time=$incoming['edit_action_time'];
-$edit_action_text=$incoming['edit_action_text'];

 // define local functions

@@ -66,11 +87,9 @@ $edit_action_text=$incoming['edit_action_text'];
 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
-    $sbcolor=P_SIDEBAR_COLOR;
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
-    $sbcolor=SIDEBAR_COLOR;
    $mbgcolor=MENUBG_COLOR;
 }

@@ -92,17 +111,17 @@ $now=date("H:i:s");
 // get max report date from writeups table, validate input dates/times and set defaults
 $maxrepdate_qry=mysqli_query($drs_db,"select max(report_date) from writeups");
 $maxrepdate=mysqli_fetch_row($maxrepdate_qry)[0];
-if (!$s_report_date_start || !validateDate($s_report_date_start)) $s_report_date_start=mysqli_fetch_row(mysqli_query($drs_db,"select date_sub(curdate(),interval 30 day)"))[0];
-if (!$s_report_date_end || !validateDate($s_report_date_end)) $s_report_date_end=$maxrepdate;
-if (!$s_report_time_start || !validateTime($s_report_time_start)) $s_report_time_start="00:00:00";
-if (!$s_report_time_end || !validateTime($s_report_time_end)) $s_report_time_end="23:59:59";
-if (!$edit_action_date || !validateDate($edit_action_date)) $edit_action_date=$today;
-if (!$edit_action_time || !validateTime($edit_action_time)) $edit_action_time=$now;
+if (!isset($s_report_date_start) || !validateDate($s_report_date_start)) $s_report_date_start=mysqli_fetch_row(mysqli_query($drs_db,"select date_sub(curdate(),interval 30 day)"))[0];
+if (!isset($s_report_date_end) || !validateDate($s_report_date_end)) $s_report_date_end=$maxrepdate;
+if (!isset($s_report_time_start) || !validateTime($s_report_time_start)) $s_report_time_start="00:00:00";
+if (!isset($s_report_time_end) || !validateTime($s_report_time_end)) $s_report_time_end="23:59:59";
+if (!isset($edit_action_date) || !validateDate($edit_action_date)) $edit_action_date=$today;
+if (!isset($edit_action_time) || !validateTime($edit_action_time)) $edit_action_time=$now;


 if ($action=="add" && $role && $save) {
    $fail=false;
-    if (!$group) {
+    if ($group==NULL) {
        // group was not supplied, so create a new one
        mysqli_query($drs_db,"insert into groups(name) value(\"\")");
        $fail=mysqli_error($drs_db);
@@ -118,18 +137,24 @@ if ($action=="add" && $role && $save) {
    }
 } elseif ($action=="remove" && $role && $save) {
    $fail=false;
-    $writeups=array();
+    $writeups=[];
    $writeups_qry=mysqli_query($drs_db,"select writeupid from links where linkgroup=\"$group\"");
    while ($writeuprow=mysqli_fetch_row($writeups_qry)) {
        $writeups[]=$writeuprow[0];
    }
    foreach ($writeups as $writeup) {
-        if (!in_array($writeup,$targets)) {
+        if (!isset($targets) || !in_array($writeup,$targets)) {
            // remove writeup from group
            mysqli_query($drs_db,"delete from links where writeupid=$writeup and linkgroup=$group");
            $fail=mysqli_error($drs_db);
        }
    }
+    // if there are no longer any writeups in this group, dissolve it
+    $memb_qty_query=mysqli_query($drs_db,"select id from links where linkgroup=\"$group\"");
+    if (mysqli_num_rows($memb_qty_query) == 0) {
+		mysqli_query($drs_db,"delete from groups where id=$group");
+		$fail=mysqli_error($drs_db);
+	}
 } elseif ($action=="dissolve" && $role && $save) {
    $fail=false;
    // unassign all writeups from a group and delete the group
@@ -149,7 +174,7 @@ if ($action=="add" && $role && $save) {
    $fail=false;
    // set the status, action by, reason action date/time and append supplied text to action text
    // for all ids in group
-    if ($edit_action_text) {
+    if ($edit_action_reason!=NULL) {
        // sanitize date and time
        $edit_action_date=mysqli_real_escape_string($drs_db,$edit_action_date);
        $edit_action_time=mysqli_real_escape_string($drs_db,$edit_action_time);
@@ -161,22 +186,23 @@ if ($action=="add" && $role && $save) {
        while ($edit_row=mysqli_fetch_row($groupmem_qry)) {
            $writeup_to_edit=$edit_row[0];
            $writeup_action_text=dblookup($drs_db,"writeups","id","action_text",$writeup_to_edit);
-            $full_action_text=$writeup_action_text." STATUS CHANGED: ".$clean_edit_action_text;
+            $full_action_text=$writeup_action_text." GROUP ACTION TAKEN: ".$clean_edit_action_text;
            mysqli_query($drs_db,"update writeups set status=\"$edit_status\",action_by=\"$edit_action_by\",action_date=\"$edit_action_date\",action_time=\"$edit_action_time\",action_reason=\"$edit_action_reason\",action_text=\"$full_action_text\" where id=\"$writeup_to_edit\"");
            $fail=mysqli_error($drs_db);
        }
+    } else {
+		$fail="A status change reason was not selected.";
 	}
 }
 if ($search) {
    // strip whitespace from beginning and end of text fields
    $s_reported_by=trim($s_reported_by);
-    $s_action_text=trim($s_action_text);
    $s_discrepancy_text=trim($s_discrepancy_text);
    
    // build the query string
    $query_string="";
    // device
-    if ($s_device) {
+    if (isset($s_device)) {
        $query_string="{$query_string}(";
        $device_param="Devices:";
        foreach ($s_device as $dev_val) {
@@ -192,7 +218,7 @@ if ($search) {
        $query_string="{$query_string} and ";
    }
    // subsystem
-    if ($s_subsystem) {
+    if (isset($s_subsystem)) {
        $query_string="{$query_string}(";
        $subsystem_param="Subsystems:";
        foreach ($s_subsystem as $sub_val) {
@@ -208,7 +234,7 @@ if ($search) {
        $query_string="{$query_string} and ";
    }
    // discovered
-    if ($s_discovered) {
+    if (isset($s_discovered)) {
        $query_string="{$query_string}(";
        $discovered_param="{$discovered_term_short}s:";
        foreach ($s_discovered as $disc_val) {
@@ -224,7 +250,7 @@ if ($search) {
        $query_string="{$query_string} and ";
    }
    // functional
-    if ($s_functional) {
+    if (isset($s_functional)) {
        $query_string="{$query_string}(";
        $func_param="$functional_term:";
        foreach ($s_functional as $func_val) {
@@ -239,7 +265,7 @@ if ($search) {
        $query_string="{$query_string} and ";
    }
    // status
-    if ($s_status) {
+    if (isset($s_status)) {
        $query_string="{$query_string}(";
        $status_param="Status:";
        foreach ($s_status as $stat_val) {
@@ -267,7 +293,7 @@ if ($search) {
    $query_string="{$query_string} and ";
    $reporttime_param="Report time between {$s_report_time_start} and {$s_report_time_end}";
    // discrepancy text
-    if ($s_discrepancy_text) {
+    if (isset($s_discrepancy_text)) {
        $query_string="{$query_string}(";
        $query_string="{$query_string}discrepancy_text like \"%{$s_discrepancy_text}%\"";
        $query_string="{$query_string})";
@@ -277,7 +303,7 @@ if ($search) {
        $discrepancytext_param="Text in discrepancy: any";
    }
    // reported by
-    if ($s_reported_by) {
+    if (isset($s_reported_by)) {
        $query_string="{$query_string}(";
        $query_string="{$query_string}reported_by like \"%{$s_reported_by}%\"";
        $query_string="{$query_string})";
@@ -304,6 +330,7 @@ banner($print);
 echo "<br>";

 if ($action=="add") {
+    if (!isset($targets)) $targets=[];
    if (count($targets) > 1) {
        $plural="s";
    } else {
@@ -317,7 +344,7 @@ if ($action=="add") {
    if ($save) {
        // show the group
        $mode="view";
-        group_table($group,$role,$mode);
+        group_detail($group,$role,$mode);
        if ($role) {
            // show buttons
            echo "
@@ -621,7 +648,7 @@ if ($action=="add") {
        <input type=\"hidden\" name=\"group\" value=\"$group\">
        <input type=\"hidden\" name=\"action\" value=\"remove\">
        ";
-        group_table($group,$role,"select","all");
+        group_detail($group,$role,"select","all");
        echo "
        Deselect the writeups you want to remove from this group. <br><br>
        <b>NOTE:</b> Deselecting them all will dissolve the group.
@@ -653,7 +680,7 @@ if ($action=="add") {
        }
        // show the group
        $mode="view";
-        group_table($group,$role,$mode);
+        group_detail($group,$role,$mode);
        if ($role) {
            // show buttons
            echo "
@@ -694,7 +721,7 @@ if ($action=="add") {
    }
    // show the group
    $mode="view";
-    group_table($group,$role,$mode);
+    group_detail($group,$role,$mode);
    if ($role) {
        // show buttons
        echo "
@@ -720,7 +747,7 @@ if ($action=="add") {
    }
    // show the group
    $mode="view";
-    group_table($group,$role,$mode);
+    group_detail($group,$role,$mode);
    if ($role && ! $save) {
        // show action form
        echo "
@@ -775,9 +802,9 @@ if ($action=="add") {
        <select name=\"edit_action_reason\" id=\"reason\">
        ";
        $reasrow=mysqli_query($drs_db,"select id,text from reasons where active is true order by id asc");
-        if (!$action_reason) echo "<option selected></option>";
+        if ($edit_action_reason==NULL) echo "<option selected></option>";
        while ($reasitem=mysqli_fetch_assoc($reasrow)) {
-            if ($action_reason==$reasitem["id"]) {
+            if ($edit_action_reason==$reasitem["id"]) {
                printf("<option value=\"%s\" selected>%s</option>",$reasitem["id"],$reasitem["text"]);
            } else {
                printf("<option value=\"%s\">%s</option>",$reasitem["id"],$reasitem["text"]);
@@ -818,10 +845,10 @@ if ($action=="add") {
        <hr>
        ";
    }
-    if ($group) {
+    if ($group!=NULL) {
        // show only the requested group
        $mode="view";
-        group_table($group,$role,$mode);
+        group_detail($group,$role,$mode);
        if ($role) {
            // show buttons
            echo "
@@ -841,45 +868,39 @@ if ($action=="add") {
        }
        echo "<hr><br>";
    } else {
-        // show all groups
-        $mode="view";
-        $groups_qry=mysqli_query($drs_db,"select id from groups");
+        // show group table
+        $groups_qry=mysqli_query($drs_db,"select * from groups");
        if (mysqli_num_rows($groups_qry)) {
+            echo "
+	        <br><br>
+	        <table border=\"1\" cellpadding=\"5\" style=\"width:100%;\">
+	            <tr>
+	                <th style=\"width:1%;\">ID</th>
+	                <th>Name</th>
+	                <th style=\"width:1%;\">Writeups assigned</th>
+	            </tr>
+	        ";
            while ($grouprow=mysqli_fetch_assoc($groups_qry)) {
-                if ($expandgrp == $grouprow['id']) {
-                    group_table($grouprow['id'],$role,$mode,"none",$expandgrp);
-                    if ($role) {
-                        // show buttons
-                        echo "
-                        <form method=post action=\"groups.php\">
-                        <input type=\"hidden\" name=\"group\" value=\"{$grouprow['id']}\">
-                        <button name=\"action\" value=\"add\" type=\"submit\">Add writeups to this group</button>
-                        &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
-                        <button name=\"action\" value=\"remove\" type=\"submit\">Remove writeups from this group</button>
-                        &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
-                        <button name=\"action\" value=\"dissolve\" type=\"submit\">Dissolve this group</button>
-                        &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
-                        <button name=\"action\" value=\"setname\" type=\"submit\">Set name for this group</button>
-                        &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
-                        <button name=\"action\" value=\"takeaction\" type=\"submit\">Take group action</button>
-                        </form>
-                        ";
-                    }
+				$num_query=mysqli_query($drs_db,"select id from links where linkgroup={$grouprow['id']}");
+				$num_writeups=mysqli_num_rows($num_query);
+				if($grouprow['name']=="") {
+					$name_text="Group {$grouprow['id']} has not been named";
 				} else {
-                    echo "
-                    <a href=\"groups.php?expandgrp={$grouprow['id']}\" style=\"text-decoration:none\">
-                    <img src=\"icons/plus-white.png\" alt=\"Expand group\">
-                    </a>
-                    ";
-                    $groupname=dblookup($drs_db,"groups","id","name",$grouprow['id']);
-                    if ($groupname == "") {
-                        echo "<b>Group ID:</b> &nbsp;{$grouprow['id']}";
-                    } else {
-                        echo "<b>Group Name:</b> &nbsp;$groupname";
+					$name_text="{$grouprow['name']}";
 				}
+				// print table row
+				printf(
+	            "<tr>
+	            <td align=\"center\" valign=\"top\"><a href=\"groups.php?group=%s\" title=\"View or change details of this group\">%s</a></td>
+	            <td valign=\"top\">%s</td>
+	            <td align=\"center\" valign=\"top\">%s</td>
+	            </tr>\n",
+	            $grouprow["id"],$grouprow["id"],
+	            $name_text,
+	            $num_writeups
+	            );
 	        }
-                echo "<br><br>";
-            }
+	        echo "</table><br>";
 		} else {
 			echo "<br>No writeup groups were found.<br><br><br>";
 		}
--- a/distfiles/login.php
+++ b/distfiles/login.php
@@ -2,24 +2,49 @@
 /*
    login.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
-
-$print=$_REQUEST['print'];
-$userid=$_REQUEST['userid'];
-$userlogin=$_REQUEST['userlogin'];
-$pass=$_REQUEST['pass'];
-$login=$_REQUEST['login'];
-$cancel=$_REQUEST['cancel'];
-
-if ($cancel) {
-    session_destroy();
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
 }

+// import incoming arrays
+if ($print) {
+    // if printer friendly was clicked, values will be passed in serialized
+    // form as "all_parameters" so we need to load those into $incoming[]
+    $incoming=unserialize($_REQUEST['all_parameters']);
+} else {
+    // copy $_REQUEST[] to $incoming[] 
+    $incoming=arrayCopy($_REQUEST);
+}
+
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+* possible keys are:
+* userid
+* userlogin
+* pass
+* login
+* cancel
+*/
+
+if (!isset($userlogin)) $userlogin=NULL;
+if (!isset($pass)) $pass=NULL;
+
+if (isset($cancel)) {
+	session_destroy();
+} else {
+	$cancel=false;
+}
+
+
 $appname=APP_NAME;

 if ($print) {
@@ -44,7 +69,7 @@ if(!$print){
    pageblock("left","end");
 }
 pageblock("right","begin");
-if ($login) {
+if (isset($login)) {
    // get the id from the userlogin
    $userid=dblookup($drs_db,"users","login","id",$userlogin);
    $useractive=dblookup($drs_db,"users","id","active",$userid);
--- a/distfiles/profile.php
+++ b/distfiles/profile.php
@@ -2,15 +2,20 @@
 /*
    profile.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to index.php on cancel button press
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
    header("Location:index.php");
@@ -30,7 +35,6 @@ if (!$role) {
 }

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming[]
@@ -40,24 +44,34 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-$update_colors=$incoming['update_colors'];
-$reset_colors=$incoming['reset_colors'];
-$newbgc=$incoming['newbgc'];
-$newmbgc=$incoming['newmbgc'];
-$newtc=$incoming['newtc'];
-$newlc=$incoming['newlc'];
-$newvlc=$incoming['newvlc'];
-$newhc=$incoming['newhc'];
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+* possible keys are:
+* update_colors
+* reset_colors
+* newbgc
+* newmbgc
+* newtc
+* newlc
+* newvlc
+* newhc
+* edit_user
+* update_user
+* user_id
+* user_fname
+* user_lname
+* user_login
+* user_pass
+* user_passconf
+*/

-$edit_user=$incoming['edit_user'];
-$update_user=$incoming['update_user'];
 $user_id=$userid;  // ensures that I can only change my own profile
-$user_fname=$incoming['user_fname'];
-$user_lname=$incoming['user_lname'];
-$user_login=$incoming['user_login'];
-$user_pass=$incoming['user_pass'];
-$user_passconf=$incoming['user_passconf'];
+
+if (!isset($update_colors)) $update_colors=false;
+if (!isset($reset_colors)) $reset_colors=false;
+if (!isset($edit_user)) $edit_user=false;
+if (!isset($update_user)) $update_user=false;

 // define local functions

@@ -65,7 +79,7 @@ $user_passconf=$incoming['user_passconf'];
 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
    $mbgcolor=MENUBG_COLOR;
@@ -94,6 +108,9 @@ if ($reset_colors) {
    echo "<meta http-equiv='refresh' content='0'>";
 }

+$usernameunique_err=$fnamesuppld_err=$lnamesuppld_err=$loginsuppld_err=false;
+$loginunique_err=$passcomplex_err=$passmatch_err=false;
+
 if ($edit_user) {
    if ($update_user) {
        // do error checking
@@ -104,6 +121,7 @@ if ($edit_user) {
        // test for first name supplied
        if (strlen(trim($user_fname))) {
            $fnamesuppld=true;
+            $fnamesuppld_err=false;
        } else {
            $fnamesuppld=false;
            $fnamesuppld_err=true;
@@ -111,6 +129,7 @@ if ($edit_user) {
        // test for last name supplied
        if (strlen(trim($user_lname))) {
            $lnamesuppld=true;
+            $lnamesuppld_err=false;
        } else {
            $lnamesuppld=false;
            $lnamesuppld_err=true;
@@ -122,13 +141,16 @@ if ($edit_user) {
            $nameunique_err=true;
            } else {
                $nameunique=true;
+                $nameunique_err=false;
            }
        } else {
            $nameunique=true;
+            $nameunique_err=false;
        }
        // test for login supplied
        if (strlen(trim($user_login))) {
            $loginsuppld=true;
+            $loginsuppld_err=false;
        } else {
            $loginsuppld=false;
            $loginsuppld_err=true;
@@ -140,9 +162,11 @@ if ($edit_user) {
                $loginunique_err=true;
            } else {
                $loginunique=true;
+                $loginunique_err=false;
            }
        } else {
            $loginunique=true;
+            $loginunique_err=false;
        }
        // sanitize first name, last name, login
        $clean_fname=mysqli_real_escape_string($drs_db,$user_fname);
@@ -154,12 +178,14 @@ if ($edit_user) {
            $passresults=validate_password($user_pass,$user_passconf);
            if ($passresults['match']) {
                $passmatch=true;
+                $passmatch_err=false;
            } else {
                $passmatch=false;
                $passmatch_err=true;
            }
            if ($passresults['complex']) {
                $passcomplex=true;
+                $passcomplex_err=false;
            } else {
                $passcomplex=false;
                $passcomplex_err=true;
--- a/distfiles/search.php
+++ b/distfiles/search.php
@@ -2,15 +2,32 @@
 /*
    search.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

-if ($_REQUEST['exportcsv']) {
-	$csv_filename="OpenDRS_Search_Results_" . date("Y-m-d_His") . ".csv";
+// redirect to search.php on cancel button press
+if (array_key_exists('cancel',$_REQUEST)) {
+    header("Cache-Control:no-cache, must-revalidate");
+    header("Pragma:no-cache");
+    header("Location:search.php");
+    exit();
+}
+
+// assign variables from constants
+$appname=APP_NAME;
+
+if (array_key_exists('exportcsv',$_REQUEST)) {
+	$exportcsv=true;
+	$csv_filename="{$appname}_Search_Results_" . date("Y-m-d_His") . ".csv";
 	// disable caching
    $now = gmdate("D, d M Y H:i:s");
    header("Expires: Tue, 03 Jul 2001 06:00:00 GMT");
@@ -25,51 +42,69 @@ if ($_REQUEST['exportcsv']) {
    // disposition / encoding on response body
    header("Content-Disposition: attachment;filename={$csv_filename}");
    header("Content-Transfer-Encoding: binary");
+} else {
+	$exportcsv=false;
 }

 // import session variables
-if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];
+if (isset($_SESSION['userid'])) {
+	$userid=$_SESSION['userid'];
+} else {
+	$userid=NULL;
+}

 // import incoming arrays
-$print=$_REQUEST['print'];
-$exportcsv=$_REQUEST['exportcsv'];
 if ($print || $exportcsv) {
    // if printer friendly or export csv was clicked, values will be 
    // passed in serialized form as "all_parameters" so we need to load
    // those into $incoming[]
    $incoming=unserialize($_REQUEST['all_parameters']);
 } else {
-    if (!$_REQUEST['cancel']) $incoming=arrayCopy($_REQUEST);
+    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-$search=$incoming['search'];
-$viewtype=$incoming['viewtype'];
-$s_device=$incoming['s_device'];
-$s_discovered=$incoming['s_discovered'];
-$s_functional=$incoming['s_functional'];
-$s_reported_by=$incoming['s_reported_by'];
-$s_report_date_start=$incoming['s_report_date_start'];
-$s_report_date_end=$incoming['s_report_date_end'];
-$s_report_time_start=$incoming['s_report_time_start'];
-$s_report_time_end=$incoming['s_report_time_end'];
-$s_action_date_start=$incoming['s_action_date_start'];
-$s_action_date_end=$incoming['s_action_date_end'];
-$s_action_time_start=$incoming['s_action_time_start'];
-$s_action_time_end=$incoming['s_action_time_end'];
-$s_action_by=$incoming['s_action_by'];
-$s_action_reason=$incoming['s_action_reason'];
-$s_action_text=$incoming['s_action_text'];
-$s_subsystem=$incoming['s_subsystem'];
-$s_id=$incoming['s_id'];
-$s_discrepancy_text=$incoming['s_discrepancy_text'];
-$s_status=$incoming['s_status'];
-$s_group=$incoming['s_group'];
-$sort=$incoming['sort'];
-$order=$incoming['order'];
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+* possible keys are:
+* search
+* viewtype
+* s_device
+* s_discovered
+* s_functional
+* s_reported_by
+* s_report_date_start
+* s_report_date_end
+* s_report_time_start
+* s_report_time_end
+* s_action_date_start
+* s_action_date_end
+* s_action_time_start
+* s_action_time_end
+* s_action_by
+* s_action_reason
+* s_action_text
+* s_subsystem
+* s_id
+* s_discrepancy_text
+* s_status
+* s_group
+* sort
+* order
+*/

-// assign variables from constants
-$appname=APP_NAME;
+if (!isset($search)) $search=false;
+if (!isset($viewtype)) $viewtype="summary";
+if (!isset($s_id)) $s_id=NULL;
+if (!isset($s_discrepancy_text)) $s_discrepancy_text=NULL;
+if (!isset($s_reported_by)) $s_reported_by=NULL;
+if (!isset($s_action_text)) $s_action_text=NULL;
+if (!isset($s_action_date_start)) $s_action_date_start=NULL;
+if (!isset($s_action_date_end)) $s_action_date_end=NULL;
+if (!isset($s_action_time_start)) $s_action_time_start=NULL;
+if (!isset($s_action_time_end)) $s_action_time_end=NULL;
+if (!isset($sort)) $sort=NULL;
+if (!isset($order)) $order=NULL;

 if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
@@ -93,10 +128,10 @@ if (! $exportcsv) framework("begin","$appname",$pgtitle,$print);
 // get min, max report and action_dates from writeups table, validate input dates/times and set defaults
 $minmaxqry=mysqli_query($drs_db,"select min(report_date),max(report_date),min(action_date),max(action_date) from writeups");
 $minmaxdates=mysqli_fetch_row($minmaxqry);
-if (!$s_report_date_start || !validateDate($s_report_date_start)) $s_report_date_start=$minmaxdates[0];
-if (!$s_report_date_end || !validateDate($s_report_date_end)) $s_report_date_end=$minmaxdates[1];
-if (!$s_report_time_start || !validateTime($s_report_time_start)) $s_report_time_start="00:00:00";
-if (!$s_report_time_end || !validateTime($s_report_time_end)) $s_report_time_end="23:59:59";
+if (!isset($s_report_date_start) || !validateDate($s_report_date_start)) $s_report_date_start=$minmaxdates[0];
+if (!isset($s_report_date_end) || !validateDate($s_report_date_end)) $s_report_date_end=$minmaxdates[1];
+if (!isset($s_report_time_start) || !validateTime($s_report_time_start)) $s_report_time_start="00:00:00";
+if (!isset($s_report_time_end) || !validateTime($s_report_time_end)) $s_report_time_end="23:59:59";

 if ($search) {
    // strip whitespace from beginning and end of text fields
@@ -303,14 +338,21 @@ if ($search) {
    $query_string="select * from writeups where {$query_string} order by $sort $order";
    
    // group membership
-    if ($s_group) {
-        $group_param="Group member:";
+    if (isset($s_group)) {
+        $group_param="Group member: ";
+        // create an array of writeups that are members of the groups specified
+        $group_writeups=[];
        foreach ($s_group as $group_val) {
-            if ($group_val=="0") $group_dsp="No";
-            if ($group_val=="1") $group_dsp="Yes";
-            $group_param="{$group_param} {$group_dsp}, ";
+            $wulink_query=mysqli_query($drs_db,"select writeupid from links where linkgroup=$group_val");
+            while($wulinkrow=mysqli_fetch_assoc($wulink_query)){
+				$group_writeups[]=$wulinkrow['writeupid'];
+			}
+			$group_name=dblookup($drs_db,"groups","id","name",$group_val);
+			$group_param="{$group_param} <font title=\"{$group_name}\">{$group_val}</font>, ";
 		}
 		$group_param=rtrim($group_param,", ");
+    } else {
+		$group_param="Group member: any";
 	}
 }

@@ -495,20 +537,31 @@ if (! $exportcsv) {
 	    ";
 	    // Group status cell **************
 	    echo "
-	    Group Member?<br>
+	    Group Assignments:<br>
+	    <select style=\"max-width:40%;\" name=\"s_group[]\" id=\"ms-group\" multiple title=\"Select the groups the results should be a member of. If you uncheck them all, this field will not be included in the search.\">
 	    ";
-	    if ($search) {
-	        $yesgroupstate=$nogroupstate="";
-	        if (in_array("1",$s_group,true)) $yesgroupstate="selected";
-	        if (in_array("0",$s_group,true)) $nogroupstate="selected";
+	    if (!isset($s_group)) $s_group=[];
+	    $grow=mysqli_query($drs_db,"select * from groups order by id asc");
+	    while ($gitem=mysqli_fetch_assoc($grow)) {
+	        if ($gitem["name"]=="") {
+				$gname="Group ".$gitem["id"];
 			} else {
-	        $yesgroupstate=$nogroupstate="selected";
-	    }echo "
-	    <select name=\"s_group[]\" id=\"ms-group\" multiple title=\"If you uncheck all, then this field will not be included in the search.\">
-	    <option value=\"1\" $yesgroupstate title=\"Writeup is a member of a group\">Show group members</option>
-	    <option value=\"0\" $nogroupstate title=\"Writeup is not a member of a group\">Show non group members</option>
+				$gname=$gitem["name"];
+			}
+	        if($search) {
+		        if (in_array($gitem["id"],$s_group,true)) {
+		            printf("<option value=\"%s\" selected>%s</option>",$gitem["id"],$gname);
+		        } else {
+		            printf("<option value=\"%s\">%s</option>",$gitem["id"],$gname);
+		        }
+		    } else {
+				printf("<option value=\"%s\">%s</option>",$gitem["id"],$gname);
+			}
+	    }
+	    echo "
 	    </select>
 	    ";
+	    	    
 	    // ************************************
 	    echo "
 	    </td></tr>
@@ -549,7 +602,11 @@ if (! $exportcsv) {
 	    ";
 	    $persrow=mysqli_query($drs_db,"select id,firstname,lastname from users order by lastname asc");
 	    while ($persitem=mysqli_fetch_assoc($persrow)) {
+	        if (!$search || in_array($persitem["id"],$s_action_by,true)) {
 	            printf("<option value=\"%s\" selected>%s %s</option>",$persitem["id"],$persitem["firstname"],$persitem["lastname"]);
+	        } else {
+	            printf("<option value=\"%s\">%s %s</option>",$persitem["id"],$persitem["firstname"],$persitem["lastname"]);
+	        }
 	    }
 	    echo "
 	    </select>
@@ -567,7 +624,11 @@ if (! $exportcsv) {
 	    ";
 	    $reasrow=mysqli_query($drs_db,"select id,text from reasons order by id asc");
 	    while ($reasitem=mysqli_fetch_assoc($reasrow)) {
+	        if (!$search || in_array($reasitem["id"],$s_action_reason,true)) {
 	            printf("<option value=\"%s\" selected>%s</option>",$reasitem["id"],$reasitem["text"]);
+	        } else {
+	            printf("<option value=\"%s\">%s</option>",$reasitem["id"],$reasitem["text"]);
+	        }
 	    }
 	    echo "
 	    </select>
@@ -759,34 +820,20 @@ if ($search) {
 	}
    $writeup=mysqli_query($drs_db,$query_string);
    // create an array of ids returned by the query string
-    $result_ids=array();
+    $result_ids=[];
    while ($eachid=mysqli_fetch_assoc($writeup)) {
        $result_ids[]=$eachid['id'];
    }
-    mysqli_data_seek($writeup,0);
-    // create an array of all ids in groups
-    $groupmems=array();
-    $groupmem_qry=mysqli_query($drs_db,"select writeupid from links");
-    while ($groupmemrow=mysqli_fetch_row($groupmem_qry)) {
-        $groupmems[]=$groupmemrow[0];
-    }
-    $groupmems=array_unique($groupmems);
-    // determine how many group members are in results
-    $member_count=0;
-    foreach($result_ids as $result_id) {
-        if (in_array($result_id,$groupmems)) $member_count += 1;
-    }
-    if (in_array("1",$s_group)) $show_groupmems=true;
-    if (in_array("0",$s_group)) $show_nongroupmems=true;
    
-    if ($show_groupmems == $show_nongroupmems) $num_results=mysqli_num_rows($writeup);    //show members and nonmembers
-    if ($show_groupmems && !$show_nongroupmems) $num_results=$member_count;    //only show members
-    if (!$show_groupmems && $show_nongroupmems) $num_results=mysqli_num_rows($writeup)-$member_count;    //only show nonmembers
+    mysqli_data_seek($writeup,0);
+    if (!isset($group_writeups)) $group_writeups=[];
+    reset($group_writeups);
+    $num_results=mysqli_num_rows($writeup);
    if ($num_results > 0) {
        if ($exportcsv) {
 			// generate csv file
 			// create an array of lines of the csv data
-		    $csv_data=array();
+		    $csv_data=[];
 			$csv_data[]=['WriteupID','Status',$device_term,'Subsystem',$discovered_term_short,$functional_term,'Discrepancy','Group','Report date','Report time','Reported by','Action taken by','Status Change Reason','Action taken','Action date','Action time'];
 		    
 			$csv_fp=fopen('php://temp', 'w+');
@@ -869,14 +916,10 @@ if ($search) {
                // action time for csv
                $csv_action_time="{$tablerow["action_time"]}";
                
-                
-                
-                if (($show_groupmems == $show_nongroupmems) || ($is_member && $show_groupmems) || (!$is_member && $show_nongroupmems)) {
                // add line of results to csv array
                $csv_data[]=[$csv_id, $csv_status_text, $csv_dname, $csv_ssname, $csv_discovered, $csv_func_text, $csv_disc_txt, $csv_member_group_name, $csv_report_date, $csv_report_time, $csv_reported_by_text, $csv_action_by, $csv_reasonname, $csv_action_text, $csv_action_date, $csv_action_time];
+            }
            
-                }
-            }
            foreach ($csv_data as $csv_fields) {
 				// add row to csv buffer
 				fputcsv($csv_fp, $csv_fields);
@@ -886,7 +929,6 @@ if ($search) {
 			rewind($csv_fp);
 			// send file contents
 			$csv_contents=stream_get_contents($csv_fp);
-			//fpassthru($csv_fp);
 			// Close our pointer and free up memory and /tmp space
 			fclose($csv_fp);
 			echo $csv_contents;
@@ -946,11 +988,11 @@ if ($search) {
 	                        }
 	                        $disc_txt=$disc_txt."<div align=\"right\"><a href=\"groups.php?group=$group_num\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"$imgtitle\"></a></div>";
 	                    } else {
-	                        $disc_txt=$disc_txt."<div align=\"right\"><a href=\"groups.php\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"View writeup groups\"></a></div>";
+	                        $disc_txt=$disc_txt."<div align=\"right\"><a href=\"writeupdetail.php?id={$tablerow['id']}\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"Member of $group_count groups. Click here to view.\"></a></div>";
 	                    }
 	                }
 	                
-	                if (($show_groupmems == $show_nongroupmems) || ($is_member && $show_groupmems) || (!$is_member && $show_nongroupmems)) {
+	                if(in_array($tablerow['id'],$group_writeups) || count($s_group)==0) { 
 	                    // print table row
 	                    printf(
 	                    "<tr>
@@ -985,7 +1027,7 @@ if ($search) {
 	                // determine if this is a member of a group
 	                $member_qry=mysqli_query($drs_db,"select linkgroup from links where writeupid=\"{$tablerow['id']}\"");
 	                $is_member=mysqli_num_rows($member_qry);
-	                if (($show_groupmems == $show_nongroupmems) || ($is_member && $show_groupmems) || (!$is_member && $show_nongroupmems)) {
+	                if(in_array($tablerow['id'],$group_writeups) || count($s_group)==0) {
 	                    displaywriteup($tablerow['id']);
 	                    echo "<br>";
 	                }
--- a/distfiles/settings.php
+++ b/distfiles/settings.php
@@ -2,7 +2,7 @@
 /*
    settings.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */
@@ -35,17 +35,23 @@ $configqry=mysqli_query($drs_db,"select name,value from config");
 while ($configrow = mysqli_fetch_assoc($configqry)) {
    $constname=strtoupper($configrow['name']);
    if (isset($userid)) {
-        $usrval=mysqli_fetch_row(mysqli_query($drs_db,"select value from profile where name=\"{$configrow['name']}\" and user=\"$userid\""))[0];
+        $usrvalqry=mysqli_query($drs_db,"select value from profile where name=\"{$configrow['name']}\" and user=\"$userid\"");
+        if (mysqli_num_rows($usrvalqry) > 0) {
+			$usrrow=mysqli_fetch_row($usrvalqry);
+			$usrval=$usrrow[0];
 		}
-    if ($usrval) {
+    }
+    if (isset($usrval)) {
        $constvalue=$usrval;
+        unset($usrval);
    } else {
        $constvalue=$configrow['value'];
    }
-    define("$constname","$constvalue");
+    if (!defined("$constname")) define("$constname","$constvalue");
 }

-//report no errors
+// level of error reporting. Set to 0 for production or E_ALL for development/troubleshooting
 error_reporting(0);
+//error_reporting(E_ALL);

 ?>
--- a/distfiles/writeupdetail.php
+++ b/distfiles/writeupdetail.php
@@ -2,15 +2,20 @@
 /*
    writeupdetail.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // redirect to writeups.php on change cancel
-if ($_REQUEST['cancel']) {
+if (array_key_exists('cancel',$_REQUEST)) {
    $id=$_REQUEST['id'];
    header("Cache-Control:no-cache, must-revalidate");
    header("Pragma:no-cache");
@@ -22,7 +27,6 @@ if ($_REQUEST['cancel']) {
 if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming[]
@@ -32,31 +36,42 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
-$usersave=$incoming['usersave'];
-$techsave=$incoming['techsave'];
-$useredit=$incoming['useredit'];
-$techedit=$incoming['techedit'];
-$id=$incoming['id'];
-$device=$incoming['device'];
-$discovered=$incoming['discovered'];
-$functional=$incoming['functional'];
-$reported_by=$incoming['reported_by'];
-$report_date=$incoming['report_date'];
-$report_time=$incoming['report_time'];
-$subsystem=$incoming['subsystem'];
-$discrepancy_text=$incoming['discrepancy_text'];
-$status=$incoming['status'];
-$action_by=$incoming['action_by'];
-$action_date=$incoming['action_date'];
-$action_time=$incoming['action_time'];
-$action_reason=$incoming['action_reason'];
-$action_text=$incoming['action_text'];
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+* possible keys are:
+* usersave
+* techsave
+* useredit
+* techedit
+* id
+* device
+* discovered
+* functional
+* reported_by
+* report_date
+* report_time
+* subsystem
+* discrepancy_text
+* status
+* action_by
+* action_date
+* action_time
+* action_reason
+* action_text
+* group 
+*/
+
+if (!isset($usersave)) $usersave=false;
+if (!isset($techsave)) $techsave=false;
+if (!isset($useredit)) $useredit=false;
+if (!isset($techedit)) $techedit=false;
+if (!isset($group)) $group=[];

 // assign variables from constants
 $appname=APP_NAME;

-if ($print=="Printer Friendly") {
+if ($print) {
    $mbgcolor=P_MENUBG_COLOR;
 } else {
    $mbgcolor=MENUBG_COLOR;
@@ -93,6 +108,18 @@ if ($usersave) {
        
        // update the record in writeups
        mysqli_query($drs_db,"update writeups set device=\"$device\",discovered=\"$discovered\",functional=\"$functional\",reported_by=\"$clean_reported_by\",report_date=\"$report_date\",report_time=\"$report_time\",subsystem=\"$subsystem\",discrepancy_text=\"$clean_discrepancy_text\" where id=\"$id\"");
+        
+        // remove writeup from all groups and add to only selected groups
+        mysqli_query($drs_db,"delete from links where writeupid=\"$id\"");
+        foreach($group as &$link) {
+			if($link==0) {
+				// new group was requested
+				mysqli_query($drs_db,"insert into groups(name) value(\"\")");
+				$newgroup=mysqli_insert_id($drs_db);
+				$link=$newgroup;
+			}
+			mysqli_query($drs_db,"insert into links(linkgroup, writeupid) values(\"$link\", \"$id\")");
+		}
    }
 }
 elseif ($techsave) {
@@ -371,13 +398,76 @@ if ($useredit) {
    <td align=\"right\" valign=\"bottom\"><input type=\"submit\" name=\"usersave\" value=\"Save Changes\"></td>
    </tr>
    <tr>
-    <td></td><td></td><td align=\"right\" valign=\"bottom\">
+    <td colspan=\"2\">Group Assignments:&nbsp;&nbsp
+    ";
+    // Group multi-select ********************
+    echo "
+    <select style=\"max-width:60%;\" name=\"group[]\" id=\"ms-group\" multiple title=\"Select the groups this writeup should be a member of.\">
+    ";
+    $linkquery=mysqli_query($drs_db,"select * from links where writeupid=\"$id\"");
+    // create an array of ids returned by group query
+    $wugroups=[];
+    while ($eachlink=mysqli_fetch_assoc($linkquery)) {
+        $wugroups[]=$eachlink['linkgroup'];
+    }
+    reset($wugroups);
+    $grow=mysqli_query($drs_db,"select * from groups order by id asc");
+    printf("<option value=\"%s\">%s</option>",0,"New group");
+    while ($gitem=mysqli_fetch_assoc($grow)) {
+        if ($gitem["name"]=="") {
+			$gname="Group ".$gitem["id"];
+		} else {
+			$gname=$gitem["name"];
+		}
+        if (in_array($gitem["id"],$wugroups,true)) {
+            printf("<option value=\"%s\" selected>%s</option>",$gitem["id"],$gname);
+        } else {
+            printf("<option value=\"%s\">%s</option>",$gitem["id"],$gname);
+        }
+    }
+    echo "
+    </select>
+    ";
+    echo "
+    </td>
+    <td align=\"right\" valign=\"bottom\">
    <input type=\"submit\" name=\"cancel\" value=\"Cancel Changes\"></td>
    </tr>
    ";
 } else {
+    echo "<tr></tr><td colspan=\"2\">Group Assignments:&nbsp;&nbsp";
    $wustat=dblookup($drs_db,"writeups","id","status",$id);
-    if ($wustat==2 && !$role) $allowuseredit="disabled";
+    if ($wustat==2 && !$role) {
+		$allowuseredit="disabled";
+	} else {
+		$allowuseredit=NULL;
+	}
+    // Group multi-select ********************
+    echo "
+    <select style=\"max-width:60%;\" name=\"groupshow\" id=\"ms-group\" multiple title=\"The groups this writeup is a member of.\">
+    ";
+    $linkquery=mysqli_query($drs_db,"select * from links where writeupid=\"$id\"");
+    // create an array of ids returned by group query
+    $wugroups=[];
+    while ($eachlink=mysqli_fetch_assoc($linkquery)) {
+        $wugroups[]=$eachlink['linkgroup'];
+    }
+    reset($wugroups);
+    $grow=mysqli_query($drs_db,"select * from groups order by id asc");
+    while ($gitem=mysqli_fetch_assoc($grow)) {
+        if ($gitem["name"]=="") {
+			$gname="Group ".$gitem["id"];
+		} else {
+			$gname=$gitem["name"];
+		}
+        if (in_array($gitem["id"],$wugroups,true)) {
+            printf("<option value=\"%s\" selected disabled>%s</option>",$gitem["id"],$gname);
+        }
+    }
+    echo "
+    </select>
+    </td>
+    ";
    echo "
    <td align=\"right\" valign=\"bottom\"><input $allowuseredit type=\"submit\" name=\"useredit\" value=\"Edit this Discrepancy\"></td>
    </tr>
@@ -526,7 +616,11 @@ if ($techedit) {
    </tr>
    ";
 } else {
-    if (!$role) $live="disabled";
+    if (!$role) {
+		$live="disabled";
+	} else {
+		$live=NULL;
+	}
    echo "
    <td align=\"right\" valign=\"bottom\"><input $live type=\"submit\" name=\"techedit\" value=\"Edit this Action\"></td>
    </tr>
--- a/distfiles/writeups.php
+++ b/distfiles/writeups.php
@@ -2,18 +2,26 @@
 /*
    writeups.php
    OpenDRS Online Discrepancy Reporting System
-    Copyright (C) 2021  Rod Wright
+    Copyright (C) 2022  Rod Wright

    SPDX-License-Identifier: GPL-2.0
 */

 include("common.php");
+if (array_key_exists('print',$_REQUEST)) {
+	$print=true;
+} else {
+	$print=false;
+}

 // import session variables
-if (isset($_SESSION['userid'])) $userid=$_SESSION['userid'];
+if (isset($_SESSION['userid'])) {
+	$userid=$_SESSION['userid'];
+} else {
+	$userid=NULL;
+}

 // import incoming arrays
-$print=$_REQUEST['print'];
 if ($print) {
    // if printer friendly was clicked, values will be passed in serialized
    // form as "all_parameters" so we need to load those into $incoming[]
@@ -24,20 +32,24 @@ if ($print) {
    $incoming=arrayCopy($_REQUEST);
 }

-// load variables from incoming array
+// extract incoming array keys into variables
+extract($incoming, EXTR_SKIP);
+/*
+ * possible keys are:
+ * 
+ * view
+ * start_date
+ * end_date
+ * showtoday
+ * showyesterday
+ * show7day
+ * show30day
+ * viewtype
+ * togroup
+ * addtogroup
+ * selectedids
+*/

-$view=$incoming['view'];
-$start_date=$incoming['start_date'];
-$end_date=$incoming['end_date'];
-$showtoday=$incoming['showtoday'];
-$showyesterday=$incoming['showyesterday'];
-$show7day=$incoming['show7day'];
-$show30day=$incoming['show30day'];
-$viewtype=$incoming['viewtype'];
-
-$togroup=$incoming['togroup'];
-$addtogroup=$incoming['addtogroup'];
-$selectedids=$incoming['selectedids'];

 // assign variables from constants
 $appname=APP_NAME;
@@ -51,7 +63,7 @@ if ($print) {
 $role=dblookup($drs_db,"users","id","role",$userid);

 // define local functions
-function opentable($start_date,$end_date,$print,$drs_db,$viewtype="summary") {
+function opentable($incoming,$start_date,$end_date,$print,$drs_db,$viewtype="summary") {
 	// grab some important global variables
    global $device_term;
    global $discovered_term, $discovered_term_short, $disc_drop_data;
@@ -133,7 +145,7 @@ function opentable($start_date,$end_date,$print,$drs_db,$viewtype="summary") {
                if ($group_count == 1) {
                    $disc_txt=$disc_txt."<div align=\"right\"><a href=\"groups.php?group=$member_group\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"$imgtitle\"></a></div>";
                } else {
-                    $disc_txt=$disc_txt."<div align=\"right\"><a href=\"groups.php\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"View writeup groups\"></a></div>";
+                    $disc_txt=$disc_txt."<div align=\"right\"><a href=\"writeupdetail.php?id={$tablerow['id']}\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"Member of $group_count groups. Click here to view.\"></a></div>";
                }
            }
            
@@ -161,11 +173,11 @@ function opentable($start_date,$end_date,$print,$drs_db,$viewtype="summary") {
        }
        echo "</table>\n";
    } else {
-        if ($_REQUEST['showyesterday']) {
+        if (array_key_exists('showyesterday',$incoming)) {
            $datespec="yesterday";
-        } elseif ($_REQUEST['show7day']) {
+        } elseif (array_key_exists('show7day',$incoming)) {
            $datespec="the last 7 days";
-        } elseif ($_REQUEST['show30day']) {
+        } elseif (array_key_exists('show30day',$incoming)) {
            $datespec="the last 30 days";
        } else {
            $datespec="today";
@@ -279,7 +291,7 @@ function viewtable($start_date,$end_date,$print,$drs_db,$viewtype="summary",$rol
                    if ($group_count == 1) {
                        $disc_txt=$disc_txt."<div align=\"right\"><a href=\"groups.php?group=$member_group\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"$imgtitle\"></a></div>";
                    } else {
-                        $disc_txt=$disc_txt."<div align=\"right\"><a href=\"groups.php\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"View writeup groups\"></a></div>";
+                        $disc_txt=$disc_txt."<div align=\"right\"><a href=\"writeupdetail.php?id={$tablerow['id']}\"><img src=\"icons/block.png\" alt=\"GRP\" title=\"Member of $group_count groups. Click here to view.\"></a></div>";
                    }
                }
                
@@ -337,7 +349,12 @@ function viewtable($start_date,$end_date,$print,$drs_db,$viewtype="summary",$rol
            ";
            $tgrow=mysqli_query($drs_db,"select id,name from groups order by id asc");
            while ($tgitem=mysqli_fetch_assoc($tgrow)) {
-                printf("<option value=\"%s\">%s</option>",$tgitem["id"],$tgitem["name"]);
+                if($tgitem["name"]=="") {
+					$tgname="Group ".$tgitem["id"];
+				} else {
+					$tgname=$tgitem["name"];
+				}
+                printf("<option value=\"%s\">%s</option>",$tgitem["id"],$tgname);
            }
            echo "
            </select>
@@ -354,30 +371,31 @@ function viewtable($start_date,$end_date,$print,$drs_db,$viewtype="summary",$rol

 // use default date values if not supplied
 $today = date("Y-m-d");
-if ($start_date=="") $start_date=$today;
-if ($end_date=="") $end_date=$today;
-if ($showtoday) {
+if (!isset($start_date)) $start_date=$today;
+if (!isset($end_date)) $end_date=$today;
+if (isset($showtoday)) {
    $start_date=$today;
    $end_date=$today;
 }
-if ($showyesterday) {
+if (isset($showyesterday)) {
    $start_date=mysqli_fetch_row(mysqli_query($drs_db,"select date_sub(curdate(),interval 1 day)"))[0];
    $end_date=$start_date;
 }
-if ($show7day) {
+if (isset($show7day)) {
    $start_date=mysqli_fetch_row(mysqli_query($drs_db,"select date_sub(curdate(),interval 7 day)"))[0];
    $end_date=$today;
 }
-if ($show30day) {
+if (isset($show30day)) {
    $start_date=mysqli_fetch_row(mysqli_query($drs_db,"select date_sub(curdate(),interval 30 day)"))[0];
    $end_date=$today;
 }

-if ($view) {
+if (isset($view)) {
    $pgtitle="Recent Writeups";
 } else {
    $pgtitle="Open Writeups";
 }
+
 framework("begin","$appname",$pgtitle,$print);

 //echo "_REQUEST array <br>";
@@ -388,7 +406,7 @@ framework("begin","$appname",$pgtitle,$print);

 // ******** begin database manipulation ********

-if ($addtogroup && $togroup && $selectedids && $role) {
+if (isset($addtogroup) && isset($togroup) && isset($selectedids) && $role!=NULL) {
    $fail=false;
    if ($togroup=="newgroup") {
        // Create a new group
@@ -419,7 +437,7 @@ pageblock("right","begin");
 banner($print); 
 echo "<br>";

-if ($addtogroup) {
+if (isset($addtogroup)) {
    if (count($selectedids) > 1) {
        $plural="s";
    } else {
@@ -431,14 +449,14 @@ if ($addtogroup) {
        format_message(2,"<strong>An error was encountered when adding writeup$plural.</strong> The error was \" $fail \"");
    }
 }
-if (!$viewtype) $viewtype="summary";
+if (!isset($viewtype)) $viewtype="summary";

-if ($view==1) {
+if (isset($view)) {
    // show writeup table
    viewtable($start_date,$end_date,$print,$drs_db,$viewtype,$role);
 } else {
    // show open table
-    opentable($start_date,$end_date,$print,$drs_db,$viewtype);
+    opentable($incoming,$start_date,$end_date,$print,$drs_db,$viewtype);
 }

 echo "<br>";
--- a/install.sh
+++ b/install.sh
@@ -2,12 +2,12 @@

 #    install.sh
 #    OpenDRS Online Discrepancy Reporting System
-#    Copyright (C) 2021  Rod Wright
+#    Copyright (C) 2022  Rod Wright

 #    SPDX-License-Identifier: GPL-2.0


-DRS_VERSION="1.1.2"
+DRS_VERSION="1.3.2"
 DOC_ROOT="/var/www"
 INSTALL_LOC="opendrs"
 APACHE_USER="www-data"
@@ -78,7 +78,7 @@ then
                curr_username=`grep username $install_path/db.php | head -1 | cut -d "\"" -f2`
                curr_dbpass=`grep dbpass $install_path/db.php | head -1 | cut -d "\"" -f2`
                export MYSQL_PWD="$curr_dbpass"
-                mysqldump -u"$curr_username" $curr_dbname > $curr_dbname-`date +%Y-%m-%d_%H:%M:%S`-backup.sql
+                mysqldump --no-tablespaces -u"$curr_username" $curr_dbname > $curr_dbname-`date +%Y-%m-%d_%H:%M:%S`-backup.sql
                # back up existing installation
                echo "Backing up current installation to the package directory."
                cp -R $install_path $install_loc_in-`date +%Y-%m-%d_%H:%M:%S`-backup
@@ -91,6 +91,14 @@ then
                # copy distribution to install location
                echo "Installing distribution . . ."
                cp -R distfiles/* $install_path
+                if [ ! -L "$install_path/jquery-ui" ]
+			    then
+					ln -s $install_path/jquery-ui* $install_path/jquery-ui
+				fi
+				if [ ! -L "$install_path/index.php" ]
+			    then
+					ln -s $install_path/writeups.php $install_path/index.php
+				fi
                # set ownership
                echo "In order to set the ownership correctly, we need to know the user and"
                echo "group that the webserver expects its files to be owned by. This is"
@@ -161,6 +169,10 @@ else
    echo "This can be changed later in the application itself."
    echo -n "Installation name [OpenDRS]: "
    read new_inst_name
+    if [ "$new_inst_name" = "" ] 
+	then
+		new_inst_name="OpenDRS"
+	fi
 	echo ""
    
    # Create initial database
@@ -227,7 +239,14 @@ else
    # copy distribution to install location
    echo "Installing distribution . . ."
    cp -Rv distfiles/* $install_path
-    
+    if [ ! -L "$install_path/jquery-ui" ]
+    then
+		ln -s $install_path/jquery-ui* $install_path/jquery-ui
+	fi
+    if [ ! -L "$install_path/index.php" ]
+    then
+		ln -s $install_path/writeups.php $install_path/index.php
+	fi
    # set ownership
    echo "In order to set the ownership correctly, we need to know the user and"
    echo "group that the webserver expects its files to be owned by. This is"
--- a/opendrs-initial.sql
+++ b/opendrs-initial.sql
@@ -38,7 +38,7 @@ CREATE TABLE `banners` (
 LOCK TABLES `banners` WRITE;
 /*!40000 ALTER TABLE `banners` DISABLE KEYS */;
 INSERT INTO `banners` VALUES 
-(1,'no banner','#000000','#000000'),
+(1,'no banner','#000000','#FFFFFF'),
 (2,'UNCLASSIFIED','#009900','#FFFFFF'),
 (3,'CONFIDENTIAL','#000099','#FFFFFF'),
 (4,'SECRET','#990000','#FFFFFF'),
@@ -69,7 +69,7 @@ CREATE TABLE `config` (
 LOCK TABLES `config` WRITE;
 /*!40000 ALTER TABLE `config` DISABLE KEYS */;
 INSERT INTO `config` VALUES 
-(1,'drs_version','1.2.0','1.2.0'),
+(1,'drs_version','1.3.2','1.3.2'),
 (5,'app_name','OpenDRS - Discrepancy Reporting System','OpenDRS Discrepancy Reporting System'),
 (6,'banner','1','1'),
 (7,'background_color','0B3144','0B3144'),
@@ -172,6 +172,7 @@ CREATE TABLE `discovered` (

 LOCK TABLES `discovered` WRITE;
 /*!40000 ALTER TABLE `discovered` DISABLE KEYS */;
+INSERT INTO `discovered` VALUES (1,'Install','Initial installation',1);
 /*!40000 ALTER TABLE `discovered` ENABLE KEYS */;
 UNLOCK TABLES;

@@ -272,6 +273,7 @@ CREATE TABLE `devices` (

 LOCK TABLES `devices` WRITE;
 /*!40000 ALTER TABLE `devices` DISABLE KEYS */;
+INSERT INTO `devices` VALUES (1,'OpenDRS Server',1);
 /*!40000 ALTER TABLE `devices` ENABLE KEYS */;
 UNLOCK TABLES;

@@ -337,6 +339,7 @@ CREATE TABLE `writeups` (

 LOCK TABLES `writeups` WRITE;
 /*!40000 ALTER TABLE `writeups` DISABLE KEYS */;
+INSERT INTO `writeups` VALUES (1,1,1,1,'R. Wright',CURRENT_DATE(),CURRENT_TIME(),1,'This is a new installation of OpenDRS. There is one admin user (username: drsadmin  password: OpenDRS-1). You should immediately log in and click on Manage Database under Admin Functions, go to the User Management tab, and add yourself as a new user, making sure to click the Admin checkbox to give yourself admin rights. You should then edit the DRS Admin user by clicking the User ID number in the table of existing users, and uncheck the Active checkbox. After you have done that, you can close this writeup.',1,0,NULL,NULL,0,NULL);
 /*!40000 ALTER TABLE `writeups` ENABLE KEYS */;
 UNLOCK TABLES;
 /*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */;
--- a/opendrs-update.sql
+++ b/opendrs-update.sql
@@ -210,3 +210,19 @@ ALTER TABLE `writeups` CHANGE COLUMN `period` `discovered` int not null;

 -- Rename period_effective column of writeups table to functional
 ALTER TABLE `writeups` CHANGE COLUMN `period_effective` `functional` tinyint(1) not null;
+-- --------------------------------------
+
+-- ---------- version 1.3.0 -------------
+-- Update version number
+UPDATE config SET value="1.3.0",defaultvalue="1.3.0" WHERE name="drs_version";
+-- --------------------------------------
+
+-- ---------- version 1.3.1 -------------
+-- Update version number
+UPDATE config SET value="1.3.1",defaultvalue="1.3.1" WHERE name="drs_version";
+-- --------------------------------------
+
+-- ---------- version 1.3.2 -------------
+-- Update version number
+UPDATE config SET value="1.3.2",defaultvalue="1.3.2" WHERE name="drs_version";
+-- --------------------------------------
Author	SHA1	Message	Date
Rod Wright	2bddfba99a	Incorporated changes for release 1.3.2	2026-02-24 20:13:13 -05:00
Rod Wright	f7b91f4ef0	Incorporated changes for 1.3.1	2026-02-24 20:07:34 -05:00
Rod Wright	6e5c6e03e3	Incorporated changes for release 1.3.0	2026-02-24 19:59:54 -05:00